thetisproject / thetis

Finite element flow solver for simulating coastal and estuarine flows.
Other
70 stars 28 forks source link

Soft dependency on Goalie to avoid duplication #350

Open jwallwork23 opened 11 months ago

jwallwork23 commented 11 months ago

It does make me wonder, though, whether we should avoid the duplication so this doesn't happen again. We obviously don't want Thetis to depend on Goalie, but maybe we could put something in here so that this part of the code only works if you have Goalie installed and if so imports form2indicator?

Originally posted by @jwallwork23 in https://github.com/thetisproject/thetis/pull/349#pullrequestreview-1724230878