search

thetisproject / thetis

Finite element flow solver for simulating coastal and estuarine flows.
Other
70 stars 28 forks source link

Replace .at() interpolation in 2D callbacks #373

Open cpjordan opened 3 months ago

cpjordan commented 3 months ago

.at() raises an error when the number of processors used is large, use a VertexOnlyMesh instead for interpolation

cpjordan commented 3 months ago

Prevents the Firedrake issue #2790 whilst Firedrake issue #3080 is waiting to be resolved. This method is slower than .at() so an alternative is to add a try except with .at() before moving onto using a VertexOnlyMesh.

There are some remaining direct applications of .at() but they are for 3D examples where either the callbacks are only being used in serial or where the problem is so large that .at() is functioning fine.

cpjordan commented 3 weeks ago

The current version of Firedrake is failing, which seems to be causing all the Thetis tests to fail. Waiting for this to be updated.