search

thetrevorharmon / gatsby-theme-shopify-manager

The easiest way to start a Shopify shop on Gatsby.
https://gatsby-theme-shopify-manager.netlify.app/
MIT License
120 stars 11 forks source link

Support Gatsby 3.0 #93

Open fnebenfuehr opened 3 years ago

fnebenfuehr commented 3 years ago

Pumping the devDependency of gatsby to support gatsby 3.0 and fix the warning.

warning Plugin gatsby-theme-shopify-manager is not compatible with your gatsby version 3.0.0 - It requires gatsby@^2.19.18

Thanks for sharing this code with the community.

joshua-isaac commented 3 years ago

does this plugin not work with gatsby v3?

fnebenfuehr commented 3 years ago

It does work.

joshua-isaac commented 3 years ago

It does work.

trying to install on gatsby 3.2.1 or gatsby 3.3 gives me errors :(

laradevitt commented 3 years ago

I am using this plugin with Gatsby 3.6.0 with no issues.

joshua-isaac commented 3 years ago

I am using this plugin with Gatsby 3.6.0 with no issues.

any extra configurations? I will retry this, thanks.

laradevitt commented 3 years ago

@joshua-isaac - Sorry, I lost track of this. Not that I'm aware of. I might be able to help if I knew what errors you are getting.

krichey15 commented 3 years ago

@joshua-isaac - Sorry, I lost track of this. Not that I'm aware of. I might be able to help if I knew what errors you are getting.

I am using Gatsby 3.14.2

I followed the instructions to install gatsby-theme-shopify-manager. However when I run gatsby develop I get this same warning.

warn Plugin gatsby-theme-shopify-manager is not compatible with your gatsby version 3.14.2 - It requires gatsby@^2.19.18

I also get an error.

`ERROR #11331 PLUGIN

Invalid plugin options for "gatsby-source-shopify", configured by node_modules/gatsby-theme-shopify-manager:

warn Warning: there are unknown plugin options for "gatsby-source-shopify", configured by node_modules/gatsby-theme-shopify-manager: shopName, accessToken Please open an issue at ghub.io/gatsby-source-shopify if you believe this option is valid. not finished open and validate gatsby-configs, load plugins - 16.252s`

laradevitt commented 3 years ago

@krichey15 You can ignore the warning. Your error is unrelated. It looks like your configuration options in gatsby-config.js are in the wrong place. It should look something like this:

    {
      resolve: 'gatsby-source-shopify',
      options: {
        storeUrl: process.env.SHOPIFY_STORE_URL,
        password: process.env.SHOPIFY_PASSWORD,
      },
    },
    {
      resolve: 'gatsby-theme-shopify-manager',
      options: {
        shopName: 'my-shop',
        accessToken: process.env.SHOPIFY_TOKEN,
      },
    },
krichey15 commented 3 years ago

@laradevitt I tried that as well. Which did get rid of the error, but still had the warnings. So to get rid of the one at the bottom I had to add. the option:

' shouldConfigureSourcePlugin: false,'

to gatsby-theme-shopify-manager

However it would seem the original warning that this issue is talking about is not going away...oh well at least its just a warning.

laradevitt commented 3 years ago

@krichey15 Oh, that's right: I forgot about shouldConfigureSourcePlugin. It's been a little while. Gld you got that sorted. The warning won't go away until the maintainer changes devDependencies in package.json.