search

thetron / css3buttons_rails_helpers

Rails helpers to generate beautiful css3 buttons, based on the 'css3-github-buttons'
http://nicolasgallagher.com/lab/css3-github-buttons/
MIT License
311 stars 29 forks source link

negative background not working inside minor_button_group #14

Closed etdsoft closed 13 years ago

etdsoft commented 13 years ago

This doesn't result in red background on :hover for the last link

    <% minor_button_group do -%>
      <%= pill_button_link_to 'Show', project %>
      <%= edit_pill_button_link_to 'Edit', edit_project_path(project) %>
      <%= remove_negative_pill_button_link_to 'Destroy', project, :confirm => 'Are you sure?', :method => :delete %>
   <% end -%>

This does:

    <% button_group do -%>
      <%= pill_button_link_to 'Show', project %>
      <%= edit_pill_button_link_to 'Edit', edit_project_path(project) %>
      <%= remove_negative_pill_button_link_to 'Destroy', project, :confirm => 'Are you sure?', :method => :delete %>
   <% end -%>
thetron commented 13 years ago

Thanks for reporting this, but I'm reasonably certain this is by design - but I'm not completely sure, since I didn't design the CSS. I'm using this CSS library, which as of the current version - just makes the text red when using a negative (danger) button inside a minor button group.

That being said, I would tend to agree that on hover it should be red. The next version of the gem, will include things like missing colours for positive/safe buttons - and I may include a fix for this too.