search

thetron / mongoid-enum

Sweet enum sugar for your Mongoid documents
MIT License
117 stars 166 forks source link

Remove underscore from field name #17

Closed jeremyhaile closed 9 years ago

jeremyhaile commented 9 years ago

Since there doesn't seem to be a good reason to have an underscore in front of the field name, I've removed it. This makes it much easier to convert existing "string" fields to be an enum (i.e. no migrations required)

Do you know of any problems this would cause?

I'd love to get this merged into the main gem. Are you interested in supporting this?

Since it is not backwards compatible, would we want to make this a configuration setting?

juanibiapina commented 9 years ago

Is this still maintained? I would like to use this fix.

jeremyhaile commented 9 years ago

@juanibiapina I haven't rebased my fix on the latest version, but I'm happy to do so. I'd really like to see this get merged in.

thetron commented 9 years ago

@juanibiapina @jeremyhaile I'm still here and I really appreciate all the contributions. So sorry to you both, but i've been just getting slammed here and have been neglecting all my open source projects pretty substantially.

I'm going to have a bit more free time coming up tres soon, and I promise i'm going to follow up on this super soon :smile: :cake:

thetron commented 9 years ago

@jeremyhaile @juanibiapina Thank you both for your patience here. Whilst @jeremyhaile was definitely first on the scene, I think i'm going to opt for #16, which introduces the underscore as a configuration option, which will make this a little easier to handle those that upgrade in the future if/when I decide to change the default option.

Thank you both for your feedback though. Much appreciated :smile: :beers: