thetron / mongoid-enum

Sweet enum sugar for your Mongoid documents
MIT License
117 stars 166 forks source link

Update required major version of mongoid to 5 #24

Closed akarmes closed 9 years ago

akarmes commented 9 years ago

@thetron Mongoid 5.0.0 is released: https://rubygems.org/gems/mongoid/versions/5.0.0

Hope you will merge this PR and publish new version of mongoid-enum to rubygems soon.

akarmes commented 9 years ago

ok, it's failing because of mongoid-rspec. Hope it will be updated to mongoid 5.0.0 soon: https://github.com/mongoid-rspec/mongoid-rspec/pull/158

thetron commented 9 years ago

Ping me again when the build is green and i'll merge it straight away :smile:

akarmes commented 9 years ago

@thetron updated

1) Latest version of DatabaseCleaner doesn't work with mongoid 5, because they removed delete_all method. Anyway, I don't get why specs need DatabaseCleaner at all. After each spec it did

config.after(:each) do
  # Clean DB first time
  DatabaseCleaner.clean
  # Clean DB second time
  Mongoid.purge!
end

it seems like double work. And since DatabaseCleaner doesn't work now, I decided to remove it at all and leave Mongoid.purge!. 2) I changed mongoid.yml because of this:

NOTE: Mongoid::Config.sessions is deprecated; use clients instead. It will be removed on or after 2015-12-01.

3) Right now mongoid show verbose logs by default. And it breaks beautiful rspec output. So I set log level to "info", as it was in mongoid 4:

Mongo::Logger.logger.level = ::Logger::INFO

4) Rodrigo Pinto just published new version of mongoid-rspec, so I bumped major version inside gemspec.

akarmes commented 9 years ago

@thetron Could you say something about this PR? The built is green. I suppose you will merge it, bump mongoid-enum version and publish it to rubygems

Kris-LIBIS commented 9 years ago

I second a new release of the gem as I would like to use it again with my mongoid-5 app.

lipchyk commented 9 years ago

:+1:

karol-blaszczyk commented 9 years ago

:+1:

madwire commented 9 years ago

:+1:

temirov commented 9 years ago

:+1:

ahmet commented 9 years ago

:+1:

abourquin commented 9 years ago

:+1:

tggo commented 9 years ago

:+1:

mklnz commented 9 years ago

:+1:

gajewsky commented 9 years ago

:+1:

Kris-LIBIS commented 9 years ago

@thetron Many thumbs up, but still no release. Could you at least give us an estimate. I have a gem to release and I need to know if I have to use a different solution or not.

thetron commented 9 years ago

Finally able to take a look at this. Thanks @90yukke merging!

thetron commented 9 years ago

Released 0.4.0 on rubygems.

Kris-LIBIS commented 9 years ago

Thanks Nicholas. I used simple_enum for now, but I'll revert back to your gem soon.