search

thetron / mongoid_token

A little random, unique token generator for Mongoid documents.
MIT License
182 stars 91 forks source link

Fixes for mongoid 4 and ruby-2.0.0 #44

Closed lukef closed 10 years ago

miletbaker commented 10 years ago

Hi Nicholas, Luke, Any news on merging in this for Mongoid 4 support now it is in beta? I see the tests are failing, is that what is holding this up?

Thanks Jon

thetron commented 10 years ago

@miletbaker I was hoping to wait until the final release of Mongoid 4.0.0 dropped, but only because i'm completely swamped at my day job at the moment.

I've not had a chance to review the changes on this fork yet, but it looks pretty solid - seems like all the tests are failing, but seems to be related to the test suite (I think). Many thanks to @lukef for his efforts here though. :cake::cake::cake:

lukef commented 10 years ago

Thanks @thetron! I can definitely confirm that I'm using these in a soon to be production build and so far things are working pretty nicely. There may be a PR affected by some manual changes I made (namely the @qqshfox one) when doing the final integration (as a heads up). I tried to mark it clearly.

I can try to take a look at the test cases. When I looked at it last time it did seem to be more an issue on that end, than on the mongoid_token end.

thetron commented 10 years ago

@lukef I think I have all the build issues sorted - but i'm having some Github troubles trying to push back onto this pull request. It was all just small config things, super easy to get around.

thetron commented 10 years ago

@lukef I ended up just moving everything to a new branch and pull request here: #46