thetvdb / metadata.tvshows.thetvdb.com.v4.python

TheTVDB Official Kodi TV plugin
9 stars 3 forks source link

Scraper not falling back to Aired Order if DVD Order selected and Show doesn't have DVD Order #14

Open racer98765 opened 1 year ago

racer98765 commented 1 year ago

These shows aren't being populated if DVD Order is selected: https://thetvdb.com/series/cybersix https://thetvdb.com/series/the-book-of-boba-fett https://thetvdb.com/series/the-mandalorian https://thetvdb.com/series/megas-xlr https://thetvdb.com/series/obi-wan-kenobi https://thetvdb.com/series/severance https://thetvdb.com/series/taskmaster https://thetvdb.com/series/richard-hammonds-workshop https://thetvdb.com/series/ted-lasso https://thetvdb.com/series/top-gear

kodi.log

It looks like in the debug log the show is being found and is seeing the episodes but when it sees the show has no DVD order it fails and doesn't fall back to the aired order.

racer98765 commented 1 year ago

Here is a smaller log for just The Book of Boba Fett with the as described behavior:

kodi.log

romanvm commented 1 year ago

I'm not affiliated with TheTVDB but I don't think that a silent falling back to the default order is a good solution. If the DVD order is so different from the default order and the DVD order is missing from TheTVDB, then I'd rather have a clear indication that something is wrong so that TheTVDB people could fix it. I would definitely not want my Kodi DB to be populated with incorrect data and to have a WTF moment when starting to watch the show in question.

racer98765 commented 1 year ago

romanvm, the previous behavior for the last version of the tvdb scraper was to fallback to the default order (aired order) if you selected an alternative order (DVD order) if it wasn't found.

romanvm commented 1 year ago

Still it does not mean that the behavior of the old TheTVDB scraper was a correct one. Anyway, it's for TheTVDB to decide. The old scraper was an independent project.

antheaezzell commented 1 year ago

We are going to sync on this internally. I will get back to you @racer98765 and @romanvm