thetvdb / metadata.tvshows.thetvdb.com.v4.python

TheTVDB Official Kodi TV plugin
9 stars 3 forks source link

Warnings For Runtime #3

Closed samphomsopha closed 2 years ago

samphomsopha commented 2 years ago

There were a few warnings that popped up in the log:

2022-01-15 17:52:46.173 T:2224     INFO <general>: initializing python engine.
2022-01-15 17:52:46.361 T:2224     INFO <general>: CPythonInvoker(115, `C:\Users\Darren\AppData\Roaming\Kodi\addons\metadata.tvshows.thetvdb.com.v4.python\thetvdb.py):` script successfully run
2022-01-15 17:52:46.439 T:2224     INFO <general>: Python interpreter stopped
2022-01-15 17:52:47.471 T:7124  WARNING <general>: CVideoInfoTag::GetDurationFromMinuteString <runtime> should be in minutes. Interpreting '0' as 0 minutes

But it seemed to deal with them correctly in dealing with perhaps the wrong format for the runtime. As Karellen says, not a major issue but a minor tweak perhaps.

I did also come across one item (the TV show versions of Stig Larsen's Millennium films) which scraped on the old scraper but seems to have vanished from the new database. Those threw up a 404 error in the GUI and the log. Again it dealt with it correctly, but maybe worth noting. Log snippet of that is at https://paste.kodi.tv/abafemivev

romanvm commented 2 years ago

Regarding "TV show versions of Stig Larsen's Millennium films", they are not on TheTVDB.

romanvm commented 2 years ago

And warnings can be safely ignored. I have added support for episodes runtime information but it some cases those warning seems to be logged with no apparent reason.

romanvm commented 2 years ago

I'm closing this because all items have been addressed. The scraper won't throw errors on missing translations and regarding the warnings check my post above.

KarellenX commented 2 years ago

The scraper won't throw errors on missing translations

Is there any clue to show that information is missing from the scraper site. I would hate to think how much time I waste trying to find fault with the scraper and Kodi when the problem is at the scraper site. As I mentioned once before, those warnings were helpful, and they were exactly what is required - a warning to point you in the right direction of the problem.

romanvm commented 2 years ago

The scraper now writes warnings to the Kodi log instead of throwing errors to the user.