thetvdb / v4-api

Founded in 2006, TheTVDB is one of the longest-running community-driven TV and Movie databases. With content metadata across hundreds of thousands of TV series and movies, TheTVDB powers many of the largest media centers in the market. Developers across the world build and rely upon TheTVDB's APIs to power their apps, utilities, and projects, generating millions of API calls per day. In our GitHub repository you will find all of the necessary support and v4 API documentation to make use of TheTVDB's metadata. Come and join us!
140 stars 13 forks source link

/updates — how do you know which series an update is affecting? #6

Closed emily-helwig closed 2 years ago

emily-helwig commented 3 years ago

Results don't include series IDs when an episode is updated — users are unsure which series are the updates affecting, and how to query for the respective series id for each record in the /updates endpoint

SirSparkles commented 3 years ago

For /Update can I ask that there is an additional couple of fields added: seriesId and/or MovieId.

When receiving a new episode or artwork, it's not possible to know which series we need to update in the local cache of TVDB data. If we know from the /updates message that 'new episode 12345 is created' we don't whether that is relevant without also making a call to get details of 12345. However if we knew the series that it relates to then we could understand if this new episode is relevant to our user.

samphomsopha commented 3 years ago

@SirSparkles this is a good idea, we'll add this is the next couple of releases and we'll update this ticket.

antheaezzell commented 3 years ago

https://mediamorph.atlassian.net/browse/TVD-2223

szsori commented 3 years ago

@SirSparkles After reviewing this, I think we handle this sufficiently in other ways. For example, we include the seriesID on each episode record. We also trigger a series save when episodes are saved on the site, so if you're monitoring series updates as well, then you shouldn't have to rely on a rollup from the episode level.

If I'm misunderstanding or you think my explanation isn't sufficient, please let us know.

SirSparkles commented 3 years ago

@szsori - Based on your explanation, am I correct in thinking that: if an episode details are updates (or a new episode is added to a series) then the series is also marked as updated. (by 'marked as updated' I mean that both the lastUpdated field is updated and the series gets returned in the /updates query)

Is that correct?

If so then:

szsori commented 3 years ago

@SirSparkles Correct. You should see a series update record whenever you see an episode update record. And yes, that should be true of lastUpdated on the episode compared to the series, but there are some odd instances where an unmodified episode might get an update date without triggering the series. That can happen within our moderator bulk tools.

santah commented 3 years ago

@szsori

so if you're monitoring series updates as well, then you shouldn't have to rely on a rollup from the episode level.

Apologies, but how can we monitor series updates? Is there another endpoint to monitor updates on the series level?

I also believe series ID needs to be included in the /updates endpoint (as it was in the previous API) as not to have to make an additional call for each and every result returned from it (to just fetch the series ID from the episode ID).

santah commented 3 years ago

@samphomsopha @szsori

Anyone?

We're nearing the date (less then a month now) when the old API will stop working and there is still no way to get the updated series through the v4 API?

antheaezzell commented 3 years ago

I should have an answer for you on this in the morning @santah it was a long weekend here. We won't be deprecating the legacy APIs without first addressing substantive feedback like this on the new API.

Internal ticket - https://mediamorph.atlassian.net/browse/TVD-2453

santah commented 3 years ago

@antheaezzell

Thank you!

antheaezzell commented 3 years ago

@santah the Series id was added to updates endpoint for episodes( entityType = episodes). The documentation was also updated. Let us know if you need anything else.

antheaezzell commented 2 years ago

Closing this issue for now, let us know if you see this issue reappear.