search

thetwom / Tuner

Tuner app
GNU General Public License v3.0
189 stars 16 forks source link

[Feature] Add activity-indicator #13

Open Glitchy-Tozier opened 3 years ago

Glitchy-Tozier commented 3 years ago

Currently, when the tone gets too quiet, the line just stops moving.

With instruments that don't have much fluctuation within a single tone, the user has no idea whether the recording actually stopped or whether the note still is displayed, because all the user sees is this: 20210629_222220.jpg

I have to suggestions on how to fix this

  1. Add some lines that trail across the screen when the dot "is moving towards the right"
  2. Make it so that the trail always continues, but the trail changes color when the signal is insufficient.

Either fix is fine. Of course, I'm open to suggestions :)

thetwom commented 3 years ago

You are right, I will definitely think of improving this when I find time.

thetwom commented 3 years ago

I am currently trying around how to detect if there is a valid signal or not. Unfortunately, this is not straight forward, since the loudness of the input signal is very device dependent ... so if you are willing, you could try a test version. If you install from google play, I introduced an open test: open test Otherwise I can provide an apk here on github ..

thetwom commented 3 years ago

Activity indication is now published in version v.1.3.0.

Glitchy-Tozier commented 3 years ago

Looks pretty good!

If you wanted, you could make the inactive line even brighter and give the dot another colour, but that's nitpicking. Overall, really nice!

thetwom commented 3 years ago

not sure if this is a matter of taste. Any reason why you would make the line brighter and the dot another color?

Glitchy-Tozier commented 3 years ago

To make the two states (active, inactive) more visually distinct.

Curremtly it's okay, but I feel like I have to squint a little, focus my attention, to see what state we're in. Other tuners are designed to male this obvious even when just taking a quick glance.

Maybe making the line brighter isn't the beat choice, but giving it a distinct color(red?) might make the information more accessible.