thetwom / Tuner

Tuner app
GNU General Public License v3.0
195 stars 16 forks source link

Green point starts at random location #14

Closed Glitchy-Tozier closed 2 years ago

Glitchy-Tozier commented 3 years ago

No idea why but i feel like this could be improved.

Screenshot_20210630-073514_Tuner.jpg

thetwom commented 3 years ago

this indeed looks odd. Will have a look.

thetwom commented 3 years ago

I had a look. If I understand the your situation correctly, the behavior is indeed intended.

In your example, I guess, the following happened:

So, it's not really a random position. It could of course be worth a thought to only evaluate frequency above a certain level of loudness (so it won't show "random" start positions). Will have to check if the loudness can be reliably evaluated on a smartphone ...

Glitchy-Tozier commented 3 years ago

It could of course be worth a thought to only evaluate frequency above a certain level of loudness

A few other options i can think of that might be worth trying:

thetwom commented 3 years ago

the problem is, that the first position of the dot IS a proper position. It's indeed the first frequency which was found. It still might not make sense since it is found based on background noise ... so the question is not about an incorrectly positioned green dot, but about detecting if a found frequency is a "proper" frequency.

Glitchy-Tozier commented 3 years ago

I understand what you're saying, but I don't think it makes sense from a users perspective.

I think those are our best options:

thetwom commented 2 years ago

Closing this, since the dot actually does not start at a random location. It could appear like it since it is not clear how to take a low signal apart from no signal. Still thanks for reporting.