search

thetwom / Tuner

Tuner app
GNU General Public License v3.0
195 stars 16 forks source link

Feature request: custom tunings #17

Closed Ethanol6 closed 2 years ago

Ethanol6 commented 2 years ago

Would it be at all possible to have a feature to add custom tunings? I don't know how hard this would be to implement but it would be fantastic.

thetwom commented 2 years ago

Thanks for your interest. This is a feature, which I had in mind for quite some time, but didn't take the time to implement it.

What makes the integration a bit difficult, is to find a intuitive way to set the different tones. Also how to integrate it in the instruments list, what to do with the preset instruments, ... lots of things to think of :-). So it might take some time, until I get there ...

Ethanol6 commented 2 years ago

To me it would be pretty intuitive to just pick notes from a chromatic scale. Displayed like piano keys vertically, so you could get 1.5 to 2 octaves on screen and have some display across the top edge (so your thumb doesn't cover it up) that shows 1st note, 2nd note, 3rd note etc. I'm no UX genius though.

Or a radial menu, musicians understand the circle of fifths so radial menus are pretty intuitive. Have the center of the circle display which octave based around C, so C1, C2, C3 etc. and then the outer slices would be the notes A through G. Have a toggle for sharp or flat otherwise you'd never fit all the notes around the circle.

I think custom tunings should have their own list so that users don't have to sort through an extensive list of custom tunings just to find the preset standard tunings.

Easier said than done though!

thetwom commented 2 years ago

thanks for the feedback. I will try around the next time a bit, but I fear it will take weeks, even months to get something final there due to my currently very limited time ...

Ethanol6 commented 2 years ago

I know how FOSS works, take your time! Thanks for the fantastic app!

thetwom commented 2 years ago

I created a test version which allows using custom tunings. Maybe you are willing to test? v3.0.0-beta1

Ethanol6 commented 2 years ago

Nice! This works pretty well. I presume a few features are pending still? Deleting a custom tuning?

Here's one bug, when the screen locks, unlocking it returns to the instrument list "Edit Instrument" is displayed at the top but clicking the + no longer brings up the new tuning screen.

Edit Screen Edit Screen after lock/unlock

thetwom commented 2 years ago

Thanks for testing and also reporting the bug. Will see that I fix this soon. Mostly the implementation should be feature complete, so let me know if you are missing features. Deleting tunings already works by swiping to the left, but maybe this is not intuitive? You can also reorder by long press a custom tuning and dragging to another place. In your version also the numbers in the instruments overview are cut at the top, which will also be fixed ...

Ethanol6 commented 2 years ago

I always forget about swiping to delete. Thanks. I didn't see a way of editing a tuning after I've made it. Is this possible?

Being able to copy an instrument and then edit the copy would be convenient for alternate tunings which share notes with other tunings.

thetwom commented 2 years ago

Yes, editing a tuning is currently not possible. For a first usable version I assumed that this is not that important, but for future versions I am planning to address this. Copy-edit would also be nice, I agree, but as always one has to find good ways to allow this without cluttering the UI.

Ethanol6 commented 2 years ago

for future versions I am planning to address this.

That's perfect. Thanks so much for doing this.

thetwom commented 2 years ago

Here an update with fixes and allowing to edit/copy tunings: v3.0.0-beta2 I you are able to test, please let me know, if the UI Design is understandable.

Ethanol6 commented 2 years ago

The icons make sense. Long pressing the pencil to get to the copy option on custom instruments was a bit of a guess. Not sure what you can do there.

One issue... https://github.com/Ethanol6/Images/raw/main/CopyInstrumentIcon.png The "add instrument" + covers up the last instruments copy icon.

thetwom commented 2 years ago

Yes, it's a bit difficult to find a good way, but for now I think "long click" is a good compromise. "Copy-and-edit" is not a very necessary feature, so if people don't find it, I guess it's still quite usable :-).

You are right, it's annoying that the last instrument copy icon is covered. In the next version, I will allow to scroll a bit further ...

Ethanol6 commented 2 years ago

If this were on F-Droid I would just expect to see a note about the new features and how to use them in the release notes. I think this is very well done. Thanks so much for doing this.

thetwom commented 2 years ago

Not sure if many people read release notes :-). Lets accept for now, that some features are harder to find :-).

Will do a few more (minor) improvements during the next days, so it will take some more time until I publish the official release.

thetwom commented 2 years ago

I released the version now with a few further improvements v3.0.0. Will appear on fdroid and play store soon.