search

thetwom / Tuner

Tuner app
GNU General Public License v3.0
192 stars 16 forks source link

Back button does not close the app #32

Closed josealberto4444 closed 1 year ago

josealberto4444 commented 1 year ago

Hi, since last update (5.1.0), pressing the back button while in the main window of the app does not do anything. It used to close the app. Is it intentional? I cannot find a way to close the app different to switching it to background and then swiping it.

Thanks for the app, it helps me with my music studies. ^^

thetwom commented 1 year ago

Thanks for reporting the issue. I indeed had to adapt some logic here in order stay compatible with the latest android developments. In this process, I missed that the app won't close anymore. Will be fixed in the next version.

thetwom commented 1 year ago

Sorry, I lost a bit track of releasing the latest changes. I now created a release candidate, where the behavior is enabled again: v5.2.0-rc1. I am planning to make this official within the next days.

thetwom commented 1 year ago

Now official with v5.2.0. Thanks again for reporting the issue!

josealberto4444 commented 1 year ago

Thank you for fixing it and for the fantastic app! ^^

lindoman commented 1 year ago

For me (running Android 12 on LineageOS) the issue is still a problem. A couple of other apps I use ask me to tap the "back" button twice to exit. is that a possibility? [edit: I was mistaken, please ignore this comment]

josealberto4444 commented 1 year ago

I'm using version 5.3.0 of this app in Lineage 20.0 (Android 13) and the issue is solved. I also tested it in Lineage 18.1 (Android 11) and it also gets closed when pushing the back button, but I don't have any phone with Lineage 19 (Android 12) to test.

When you say it's not solved, you mean that there is no way to close the app with the back button or that you'd prefer to close it tapping twice?

lindoman commented 1 year ago

Apologies, I was mistaken, I was distracted by the notification of use of the microphone, which for some reason stayed on for some time after the application lost focus.

thetwom commented 1 year ago

Is the microphone notification staying on for long? The app should stop recording audio as soon as it is in the background ...

lindoman commented 1 year ago

Is the microphone notification staying on for long? The app should stop recording audio as soon as it is in the background ...

No, I got myself confused with another app also using the microphone. Only about 2 seconds in normal operation

thetwom commented 1 year ago

Ok, good. Thanks for the feedback!