search

thetwom / Tuner

Tuner app
GNU General Public License v3.0
170 stars 16 forks source link

Add 1/5-comma meantone temperament #78

Closed djpohly closed 4 months ago

djpohly commented 4 months ago

I don't exactly think I can make a great case that this should be included, so consider this more of a "pull offer". I did code it up, so I figured it was worth sharing.

The maybe-not-great case: fifth-comma does show up in tuner apps and discussions on historical temperaments from time to time, it's a personal favorite on my hammered dulcimer, and apparently it's pretty good for concertina as well.

thetwom commented 4 months ago

Thanks for looking into it, and implementing a new temperament. The implementation looks flawless. Regarding if this should be implemented in the main version or not, this is a good question. Up to now there was no need for such rules, since there were no such requests. But besides the arguments already given you have some good arguments on your side: You took the time to really get the implementation right, you provided a clean implementation and you are the first one to make such a pull request, so there is not really a problem in having to choose out of many requests, what to take and what not ...