search

thetwom / Tuner

Tuner app
GNU General Public License v3.0
190 stars 16 forks source link

Feature request: timpani #90

Open bgainor opened 6 days ago

bgainor commented 6 days ago

Would it be possible to add an instrument setting for timpani? The main issue is that you typically have three to six drums, and they'll be tuned differently for each piece. So there'd have to be a way to quickly change which notes are the targets.

thetwom commented 5 days ago

Hi, thanks for the interest. Never tried the tuner with a percussion instrument. Does it actually work?

Regarding the instrument setting, I think I first have to understand better your request. I guess, you already know that you can define your own custom instruments? Switching between two instruments are two clicks, so it should not be too much effort, no? But maybe I just do not understand the actual problem?

bgainor commented 5 days ago

I wasn't thinking about it that way, but I guess it would work to create a custom "instrument" for each piece, like different guitar tunings. As for the tuning, it does work for the most part, although I think sometimes it picks up on the harmonics instead of the fundamental, since those are pretty prominent with the timpani.

thetwom commented 4 days ago

Ok, hope that custom instruments will work for you.

If you can afford the time, it would be interesting to get a few sound samples, this could help to test the detecting algorithm better against such instruments. How to get sound samples for the tuner is described e.g. here: https://github.com/thetwom/Tuner/issues/88#issuecomment-2269587743 Would be good to know the theoretical note for each sample.