thetwom / toc2

Metronome app
GNU General Public License v3.0
159 stars 23 forks source link

Missing BPM control from notifications #16

Open XiangRongLin opened 4 years ago

XiangRongLin commented 4 years ago

When I first downloaded the app, one could (de-)increase the BPM from the notification. Now after updating the app the buttons are removed. My PR's #15 usecase is mostly so control the speed from the lockscreen, so i wanted to ask if it is planned to add to back and if it will happen in the near future. If not I could look into adding into (looks like it just commented out).

thetwom commented 4 years ago

Hi, thank for the request. Indeed, I removed this feature for the latest version, since I guessed, that this feature is not really helpful and I was not really happy with the design of the notification. In principle, it is no problem in reintegrating. Most of the work would be in adapting the layout file (notification.xml). Note, that the commented section in the file is not fully working. It uses ImageButtons for Increment/Decrement, but one would have to create more icons, which would have to change, when changing the increment step in the settings.

In previous versions, I used text buttons, so there was no need for icons. Maybe this was the better choice, but as said I was never really content with the design. You could look at the 1.6... versions to see this file, tough. It is quite a mess (the textbuttons are actually not clickable, but rather the buttons in the background to get a larger clickable area). Please feel free have a look into it and propose something. I am not sure when I would find some time, looking into this and finding a way to reintegrate this...

Best regards