thetwom / toc2

Metronome app
GNU General Public License v3.0
144 stars 23 forks source link

App crashes if tempo is 0 or very high #34

Closed qwerty287 closed 2 years ago

qwerty287 commented 3 years ago

Hi, the app crashes if the tempo is 0 BPM. I know, you don't use a metronome to set it to 0 BPM, but it just would be enough if the option in the setting doesn't accept a value of 0. It's the same if the value is very high. And if you set the value in the settings and the BPM to 1000 or more (in German), and then open the entry dialog by clicking on the BPM value and then just click OK - Metronome will think you mean 1 because it separates the numbers with a dot ("1.000"), which is interpreted as "1" (solution would be to remove the dot, for example - not a good solution - you could convert the number to an integer and then back to a string, this would solve it).

thetwom commented 3 years ago

Hi, thanks for testing the apps with non-typical values. You are absolutely right, that we should not allow 0bpm or too high values. I pushed an update now with the following changes:

Best regards and thanks again for reporting.