thetwom / toc2

Metronome app
GNU General Public License v3.0
144 stars 23 forks source link

Can't close the app #43

Closed brilnius closed 2 years ago

brilnius commented 2 years ago

Hello.

I was expecting the Android "back" button (round arrow) to close the application. Maybe in the past it did so, I don't remember as I use this method for closing other apps too. Even when the metronome is not playing, the only way to close the app (and make the notification icon go away) is to open the list of running applications and kill it (by swiping it or clicking on the cross). Maybe this issue is specific to my phone (Samsung Galaxy S7).

Not a big issue but I'm still shortly disappointed each time I want to close the app.

PS: I will update the French translations as soon as I find a good term for "scenes". :-) BTW I love this "scenes" feature.

thetwom commented 2 years ago

Hi,

I guess you are right, and the standard behavior of most apps is, that they close, when pressing the "back"-button. I indeed did not implement this behavior, but I guess it makes sense to change this in future :-).

However, I fear I have to still disappoint you a bit since even after implementing this in future it will not exactly do what you are describing. Commonly, the back button does not close apps, but it just brings them into background. This means that the notification will not go away. But what you can do (even now), is to swipe the notification away, when the metronome is not playing. This will also make the notification icon go away. I quickly checked some standard music apps, and this seems to be the standard behavior.

Looking forward to the updated translations. I agree, that it's always difficult to find good words which precisely describe the content. On the other hand, better have updated translations which are not perfect than have them missing :-)

brilnius commented 2 years ago

Being forced to swipe the notification myself when I've stopped the metronome and left the application does not seem logical to me. Honestly this is simply annoying (not very annoying of course -- let's say it's 1 on a scale from 0 to 10 :-). Ok technically the application is put into background, but the intent by using the "back" button is to leave the application, from my point of view -- or going back to the application that initially launched the metronome, but I'm not sure this is a relevant use case. On several games when I use the "back" button from the main screen, I'm asked for a confirmation before leaving the game.

What do you think of this: when I use "back" button,

If I really want to keep the notification, I simply don't use the "back" button, like we can do already (using the "home" button or the "app" list button).

thetwom commented 2 years ago

To make long story short :-). In the latest commits I more or less implemented exactly the behavior your prefer :-).

In the end, what I am trying to do is to let the app behave exactly the way the users expect. Of course this is very difficult, even more if you are no UI-designer :-). Music apps mostly don't close, when you leave them, but keep the notifications active, I guess, that you can start the music again from the notification ... games normally don't show notifications since the don't run in the background.

But in the end I agree, that it is annoying to have this notification around all the time. So, I am killing the notification now when leaving the app with the back button and it is not playing (as you describe). I guess most users don't care, so this shouldn't hurt anyone hopefully :-).

I think I will merge your translations shortly and then release ... so it should appear in fdroid/play in the next 7-14 days (fdroid is sometimes very slow to pick up new versions ...)

thetwom commented 2 years ago

Here is the release: v4.1.4. As said, if you are using fdroid it might take some days until it is available. Let me know if this solves the issue ...

thetwom commented 2 years ago

Closing this now, since this is now implemented. Thanks again for helping.

brilnius commented 2 years ago

I had the opportunity to use the metronome this week and test the new feature. I think the app is simply perfect now. ;-) Thank you again.