thetwom / toc2

Metronome app
GNU General Public License v3.0
144 stars 23 forks source link

Share only selected scenes #51

Closed cyberchrime closed 2 years ago

cyberchrime commented 2 years ago

Hi,

first of all, thank you very much for this amazing app, I find it very useful and convenient!

I noticed that currently it is only possible to share all saved scenes at once, so I was wondering if one day there would be the possibility to select multiple scenes and only share those selected scenes. I think this could be very convenient, because it would allow to share specific scenes with other musicians and help them practicing.

Thanks a lot cristalmojo

thetwom commented 2 years ago

Hi,

thanks for the suggestion. I guess the intuitive way for such a functionality is to long press on one scene and then selecting further ones. Currently "long press" is reserved to initiate dragging the scene. So I would have to find good way to allow such a change. Suggestions are welcome :-).

As a workaround for now you could of course just save all scenes, delete the ones you don't want to share and then share...and finally load again your original scenes ... but I understand that this is quite cumbersome.

cyberchrime commented 2 years ago

Hi,

thank you for your quick response! Yeah, I agree with you, that the "long press" would be really nice to initiate the selection, though I also like the possibility of rearranging them with a "long press".

Currently I have three options in mind:

  1. The less intuitive way, but still easy to use, would be to simply select an option in the DropDown Menu named something like "Select scenes", which switches the scenes list into a selection mode. In this mode, the user can select the scenes by simply pressing on them.
  2. A more intuitive way would could be the combination of the rearranging and selection feature: Long pressing an item initiates the selection mode, but still allows to rearrange
  3. The last option would be, similar to the queue in the Spotify app (see this screenshot), to always show selection boxes/circles, which allow selection by simply pressing them. However, this has the disadvantage of taking space for each list item even when no selection is to be done.

To visualize the selection, there could be little boxes/circles indicating if the item is selected or not, or the items change their color or are surrounded by boxes once they are selected.

thetwom commented 2 years ago

Thanks for the suggestions. I gave this another thought, but I am a bit worried, that introducing a multi-selection for "only" allowing to share specific scenes could confuse the users.

So I was thinking if multi-selection could become a more central element ... like the delete-all, edit, ... icons just appear if one or more scenes are selected. This would clean up the current toolbar a bit. But thinking again about it, this seems not like a real benefit.

Maybe something along option 1 would work out. E.g. if you say "share", a dialog will be presented, where you can unselect scenes you don't want to share. This would require an additional click for sharing scenes, but since sharing will be rarely used, such an additional click seems not to hurt much.

thetwom commented 2 years ago

Maybe you can test this beta: v4.5.0-beta1? Use "share scenes" as always but then you will be able to unselect/select the scenes you actually want to share.

cyberchrime commented 2 years ago

Hi @thetwom ,

thank you for the effort you put into this feature. I just tested it and it works perfectly fine, thank you a lot!

thetwom commented 2 years ago

Good to hear. I think the implementation is not perfect in a sense that selecting directly the scenes would have been nicer. But as discussed, it is in conflict with the current features. So I think it is a reasonable compromise.

Will do a release within the next days.

thetwom commented 2 years ago

Official release is tagged now v4.5.0 and should become available on fdroid and google play during the next days.