thetwom / toc2

Metronome app
GNU General Public License v3.0
151 stars 23 forks source link

Delay between sound and visual clue #72

Open loig opened 1 year ago

loig commented 1 year ago

This is a very nice app that I use daily, thanks a lot for your work!

I have issues with the synchronization between visual clues and sound however (I am using 4.8.0): the visual (the green one) seems to have a very little delay compared to the sound, sufficiently large however that it is annoying and I have to either use only the sound or only the visual. I think that this may be dependent of the hardware. Moreover, I find the animation on the notes (they become larger) a bit disturbing as well (and, I feel also that it is not synchronous with the other visual).

My suggestions would be:

thetwom commented 1 year ago

Thanks for the feedback. I am really wondering whether the synchronization is hardware dependent, if it is personal taste or if it is just not adjusted ideally. Are you able to test this on different devices?

If it is hardware or personal taste, an option to change the delay would help. If it is not adjusted ideally, we could "hardcode" the delay. However, from previous discussions I understood, that the current timing seem fine ...

Regarding the animated notes, I tend to agree that having two different visualizations (the green indicator and the notes) is not really optimal and can be confusing. On the other side I fear the feedback of switching off note animations :-). Of course, we could introduce a new setting, but I am trying to avoid new settings if not really needed.

loig commented 1 year ago

Thanks for your answers.

On another device it seem to be the same, maybe less obvious? It is not very clear. I can try to use it on this other device while playing music in the next few days, this is when I could really feel it with my own phone.

On my phone, the delay is clearly visible: I can tell that the green indicator moves after the sound. I checked with somebody else who agreed. It may very well be something taste dependent however.

I find the note animation very annoying (probably partly because it is distracting: the note is growing and then going back to its normal size, a two step, non instantaneous move while the beat itself is ponctual) to the point that I tend to hide this part of the screen with a paper. This is clearly a matter of taste however.

thetwom commented 1 year ago

I can try to provide you a version with a "delay"-option soon. At least for testing, this might help understanding how big the delay is and might give us some insights of personal taste and hardware.

Regarding the issue about the animated notes I totally agree. As you say it is a two step move which does not give a precise feedback. It definitely would be better to just color the notes or have some other indicator for showing which note is currently played. Unfortunately, this change is a bit more involved as it might appear at first sight.

loig commented 1 year ago

Having this version with delay option would be very nice. I would be ok to test it and let you know the results.

thetwom commented 1 year ago

At the moment I have no access to my signing keys so I can't create a suitable test apk. So you will have to wait for a couple of days. In case you are used to compile apps by yourself, you could checkout the "no-note-animation"-branch. There the note animations are temporarily switched off (just for testing), and with an preference option "Visual effect delay" ..

loig commented 1 year ago

I can wait for a few days. Thanks a lot for your work!

thetwom commented 1 year ago

Here is the a version: v4.9.0-rc1. I already found time to substitute the note animations with an advance marker. So this could be released as it is.

loig commented 1 year ago

Thanks! I will try it tomorrow.

thetwom commented 1 year ago

no hurry, take your time

loig commented 1 year ago

I had a rehearsal, it was a good occasion to try it.

I think the new note animation is good (I mean the cursor below the notes) and I was able to change the delay of the visual clues to my tastes, very nice (if it matters, I put -120ms as delay for visual effects).

thetwom commented 1 year ago

Thanks for trying. -120ms is more than expected, and what is also interesting is that it is negative. I really wonder if it is hardware dependent, if it is personal taste or even inaccuracies of the timing (meaning, that sometimes it is more, sometimes less ...). On the other side, it does not really matter (as long as it is not some bug, but there is no real evidence for that).

Regarding the cursor instead of the note animation, I also think it gives a more precise feel. It is not as fancy, but in the end, function is more important! Lets try and see if there is a lot of negative feedback ...