search

thetwom / toc2

Metronome app
GNU General Public License v3.0
160 stars 23 forks source link

Bug: Larger delay messes up click sound #81

Open MarkusBauer opened 5 months ago

MarkusBauer commented 5 months ago

Hi, first of all: thank you very much for this amazing and simple metronome app!

However, I noticed that sometimes the click sounds get messed up - they get a lot quieter, sound a bit "partial" and have inconsistent volume. Find a sample captured from headphone output here: metronome_sample.zip - in the beginning there's the normal sound (only one note, max volume), from 0:36 on the sound breaks.

I tracked this down to the "visual delay" setting. Setting a larger positive delay results in the messed up sound, while smaller delays seem to have to impact. But setting the delay alone is not enough, apparently the app needs a restart to trigger the bug.

So, to reproduce:

You can also see the effect when looking at the waveform: 0ms - everything is fine. 15min and a restart - first click is quieter, then everything is ok. 82ms and another restart - broken. grafik

Phone: Pixel 3a Version: 4.11.0 (newest from F-Droid) Any output is affected (speakers, jack, bluetooth), resetting or reinstalling the app doesn't fix anything. Workaround for now: reset the delay before closing the app

I'm willing to test wip apk's or compile one myself if necessary. Best Markus

thetwom commented 5 months ago

Thanks for this precise report and tracking it down to the delay setting. Without this descrition it would have been very hard to find. I probably would not have tried closing the app with a positive latency, but just temporarily change it :-).

Fortunately, I can reproduce it here, which makes finding a fix much easier. I will try to look into this as soon as possible. Thanks also for willing to test and even compile it yourself. In cases, where the bug is not reproducible, this is worth a lot! In the present case, this should not be needed, since (as said), I can reproduce it.

thetwom commented 5 months ago

Thanks to your accurate description, I was able to track down the issue quickly. Here is the fixed version: v4.12.1. Please let me know in case it doesn't fix the situation for you or in case of other issues.

Thanks again for the help!

MarkusBauer commented 5 months ago

With the provided apk, the issue also resolved for me. Looks good, thank you very much for the quick fix!