Inverts referrals-only checkbox.

trevorshannon commented 2 months ago

Since queries are stored in the URL parameters, we need to be careful about backwards-compatibility for anyone who has already saved a URL for a housing search.

This change renames the includeReferrals URL param to excludeReferrals. That results in the following behavior for the two possible types of legacy URLs:

A URL with includeReferrals=on in the URL query string will show all properties, including referral-only. This is because the includeReferrals key is no longer valid and therefore ignored. The new default behavior is to show referrals, so they are shown. The end result is no change from prior behavior.
A URL missing includeReferrals=on in the query string will also show all properties, including referral-only. This is different from current behavior, but opting to include more results for a person's saved URL should not be a problem. We do want to move to default-show of referral-only properties so this supports that.

Fixes #514

netlify[bot] commented 2 months ago

Deploy Preview for ueo ready!

Name	Link
Latest commit	c3889fa8dae75d06842a5145f5e0935d95ae4197
Latest deploy log	https://app.netlify.com/sites/ueo/deploys/66806e7b6dfe0f00081e0b73
Deploy Preview	https://deploy-preview-615--ueo.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

trevorshannon commented 2 months ago

Default housing search page (with no filters applied) shows all properties now (528 at this time)

trevorshannon commented 2 months ago

Thank you, it's nice to finally have someone to review my code!

theunitedeffort / theunitedeffort.org