search

theunitedeffort / theunitedeffort.org

The United Effort Organization website
https://theunitedeffort.org
3 stars 5 forks source link

Groups unit listings by occupancy limits. #619

Closed trevorshannon closed 2 months ago

trevorshannon commented 2 months ago

With this change, units having the same type and availability are rendered separately if their occupancy limits are different.

Old behavior

note the occupancy of 1-2 only applies to the 30% AMI unit. The 50% and 60% are listed in the database as 1-3 people):

Screenshot 2024-07-02 at 2 20 45 PM

New behavior:

Screenshot 2024-07-02 at 2 19 52 PM

I was not able to find any regressions in rendering other units though our test coverage of this type of thing could be better... Like, namely, exist in the first place.

netlify[bot] commented 2 months ago

Deploy Preview for ueo ready!

Name Link
Latest commit ee5c3616d2be251ad2aba7112ce2885796f5d4a7
Latest deploy log https://app.netlify.com/sites/ueo/deploys/668474f4990d450008cda5a0
Deploy Preview https://deploy-preview-619--ueo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

trevorshannon commented 2 months ago

@DairyProducts I am sending you these review requests assuming you are able to do them--if you don't have the time or would rather not, just let me know!

trevorshannon commented 2 months ago

Yes this originally came up with Bellarmino Place but ultimately the units with different occupancy limits also got changed to a different waitlist status so the problem got hidden in the production site. (Grouping by status is already in place.) I temporarily made all the availabilities "Waitlist Open" for my test and screenshots.