theunitedeffort / theunitedeffort.org

The United Effort Organization website
https://theunitedeffort.org
3 stars 5 forks source link

Bugfix for #175 #631

Closed DairyProducts closed 2 months ago

DairyProducts commented 2 months ago

I don't know if this fix works, I'm opening a PR so I can get the mobile link for a deploy preview. I'll close the PR if it doesn't work out.

netlify[bot] commented 2 months ago

Deploy Preview for ueo ready!

Name Link
Latest commit 03b3dc5547cabb6b6e3bf1f7e1d73a763bbb8344
Latest deploy log https://app.netlify.com/sites/ueo/deploys/66bd6741ca920a0008bf560c
Deploy Preview https://deploy-preview-631--ueo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DairyProducts commented 2 months ago

Doesn't seem to have worked, the iOS arrow emoji is still showing. Removing the superscript makes the arrow bigger though.

I'll leave the PR open to test other fixes unless someone knows another way to see a deployment preview on mobile. I guess this is one of the times the responsive design emulator won't work.

trevorshannon commented 2 months ago

Netlify will automatically create a "branch deploy" for each brach created. When you make a branch and publish it to Github, a build is kicked off and the site will be available at {branch_name}--ueo.netlify.app

This branch has a deploy at https://link-arrow-fix--ueo.netlify.app/

Any time you push new commits to the branch, Netlify will rebuild the site for you.

You can also access a local development server without the need to even make a branch or commit by using the --live option of netlify dev. See the documentation for details.

Perhaps this can be in the README as a helpful tip.

DairyProducts commented 2 months ago

This branch has a deploy at https://link-arrow-fix--ueo.netlify.app/

How does this work with branches in slashes in their name, considering the slashes are (probably) not allowed in URLs?

Edit: did some testing and it appears that slashes will be replaced by dashes.

trevorshannon commented 2 months ago

Good question. It replaces the slash with a hyphen. Unfortunately I could not find it in the documentation anywhere, but was able to verify via my Netlify account and one of your branches: https://eligibility-fss--ueo.netlify.app/

trevorshannon commented 2 months ago

Oop, I missed your comment edit! I'm glad you got it figured out.