search

theunraveler / taskwarrior-web

A web interface for the Taskwarrior todo application. Because being a neckbeard is only fun sometimes.
http://theunraveler.github.com/taskwarrior-web
MIT License
530 stars 60 forks source link

Travis build failing #104

Closed cilynx closed 6 years ago

cilynx commented 6 years ago

The Travis-CI build is failing because RSpec::Mocks::setup requires an argument under rspec 2 (what our specs written for), but can't have an argument under rspec 3 (what Travis uses by default now). Pinning rspec to <3 in taskwarrior-web.gemspec winds up throwing another error because modern versions of rake don't have last_comment. Short term, I'm trying to sort out if we can pin rake effectively. Long term, we really need to update the specs to support modern versions of rspec and rake.

cilynx commented 6 years ago

Using rvm to get a ruby 2.2 environment with rake 10.5, I can get past the rspec and rake issues, but now I'm getting a bunch of actual test failures. Will dig in more later on.

Zebradil commented 6 years ago

Do we actually need these old ruby versions? I'd like to support only the current stable releases (2.5.1 and 2.4.4 for today).

cilynx commented 6 years ago

We're on the same page. That's what I was getting at when talking about updating the specs. It appears that a lot has changed in the last few years and I figured it made the most sense to pin "old times" in order to get to a working state and then work through incremental enhancements to bring the codebase up to current expectations.

Zebradil commented 6 years ago

Did you try 2.4.4? It works without any errors for me (I ran it in docker, though).

cilynx commented 6 years ago

Using 2.4.4 and not pinning anything new in the gemspec, I don't see any issues with rspec or rake, but I'm still seeing a pile of test failures: 83 examples, 31 failures This is the same outcome I got with 2.2 and rake pinned to an older version.

Are you seeing something different?

Zebradil commented 6 years ago

I haven't run any test yet — just build and run the app itself.

cilynx commented 6 years ago

Forgot to mention this issue in #110 -- cross-linking from here.