search

theunraveler / taskwarrior-web

A web interface for the Taskwarrior todo application. Because being a neckbeard is only fun sometimes.
http://theunraveler.github.com/taskwarrior-web
MIT License
527 stars 63 forks source link

Added support for newer versions of Ruby, taskwarrior and also task server support. #76

Closed dancollins closed 8 years ago

dancollins commented 8 years ago

69 prevents taskwarrior-web from working with newer versions of taskwarrior.

74 prevents taskwarrior-web from installing on hosts with Ruby 2.2.0 (and maybe others)

This pull request includes fixes for both issues.

I've done some basic testing (navigating to the web page, adding new tasks) to confirm that this all compiles and installs.

EDIT: I added support for syncing with the task server! It seems inefficient to call 'task sync' at every request, but it's the only way to ensure the task database it up to date. It takes me about 20ms to run 'task sync' with no changes, so I guess that's not too much overhead.

dancollins commented 8 years ago

It appears as though something broke the build :( Running 'rake spec' locally showed the same problem with and without my changes. I'm not sure if this means the test system updated and this project lagged behind or if there are some actual problems...

theunraveler commented 8 years ago

Thanks for the contributions. Not sure what's up with the tests, but I can have a look sometime later.

linuxcaffe commented 8 years ago

@dancollins Please don't worry about backwards compatibility for taskwarrior-web, it has been so broken for so long that there really can't be a user-base (other than curious developers) can there?

@theunraveler am I wrong here?

matthiasbeyer commented 8 years ago

@linuxcaffe You are wrong. I'm working on a service definition for NixOS, so we can build taskwarrior-web into the system. I want to use it, at least to view my tasks. But at the moment it does not work due to errors described in #69.

And, of course, we have taskwarrior-web packaged for NixOS (disclaimer: I'm the author of the package and the maintainer of it).

linuxcaffe commented 8 years ago

@matthiasbeyer I'm delighted to be wrong in this case!

theunraveler commented 8 years ago

Covered by https://github.com/theunraveler/taskwarrior-web/pull/80, thanks!