fix: error handling for add. verifier and signer method signatures

dibrinsofor commented 1 year ago

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #363

Release Notes:

Types of changes:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected). Please ensure that your PR title is a Conventional Commit breaking change (with a !, as in feat!: change foo).

Description of the changes being introduced by the pull request: Added support for error handling for MarshalPublicKey(), Public(), PublicData()

Please verify and check that the pull request fulfills the following requirements:

[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

dibrinsofor commented 1 year ago

Couple minor changes but overall looking good! Thanks

@znewman01 just addressed, should be all good now.

mnm678 commented 1 year ago

Looks like there are a couple of formatting bugs (see the CI tests), but otherwise this looks good.

rdimitrov commented 8 months ago

@dibrinsofor - Closing the PR since we've updated the code base of go-tuf. Feel free to reopen if you find it's useful to add something similar to the new one 👍

theupdateframework / go-tuf

fix: error handling for add. verifier and signer method signatures #509