Closed mikedanese closed 7 months ago
@mikedanese - there's some things to fix so we can satisfy the CI but I agree it's better if these packages are internal π Thanks for addressing this π
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3a2b819
) 70.18% compared to head (a1b3a1f
) 70.18%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Oops, fixed.
FWIW, I was looking at using the RepositorySimulator in testutils as part of sigstore-go's test suite, but I can understand why it's probably best to keep it internal.
@codysoyland - oh, I wasn't aware of that, thanks π Given this I think it's okay to leave it as a standalone package. cc: @mikedanese
edit: @codysoyland - hey, I just saw you mentioned in the PR that eventually you came up with another workaround for the tests. I don't think there's anyone else trying to use the testutils package so far, but I'm supportive of leaving it visible if it's going to help sigstore-go with the testing.
Of course, at the end we can always revisit and move it out of internal if someone comes up with a valid use case for it π
edit: @codysoyland - hey, I just saw you mentioned in the PR that eventually you came up with another workaround for the tests. I don't think there's anyone else trying to use the testutils package so far, but I'm supportive of leaving it visible if it's going to help sigstore-go with the testing.
Of course, at the end we can always revisit and move it out of internal if someone comes up with a valid use case for it π
@rdimitrov Thanks for offering to keep it visible, but I decided late yesterday that it makes sense for us to have our own stripped down version of a repo simulator and not depend on the one here, since it may diverge and become incompatible, so I'm supportive of going ahead and merging this one!
@codysoyland - Thanks! ππ
@mikedanese - There's a few conflicts you have to fix, but otherwise we should be good to go then π
Rebased.
This prevents these libraries from being depended on from outside the module.