theupdateframework / go-tuf

Go implementation of The Update Framework (TUF)
https://theupdateframework.com
Apache License 2.0
630 stars 107 forks source link

Do not run CI for all Go versions and use caching #606

Closed rdimitrov closed 9 months ago

rdimitrov commented 9 months ago

The following PR:

codecov-commenter commented 9 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.18%. Comparing base (85bd220) to head (decacdd). Report is 29 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #606 +/- ## ======================================= Coverage 70.18% 70.18% ======================================= Files 10 10 Lines 2123 2123 ======================================= Hits 1490 1490 Misses 517 517 Partials 116 116 ``` | [Flag](https://app.codecov.io/gh/theupdateframework/go-tuf/pull/606/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theupdateframework) | Coverage Δ | | |---|---|---| | [Go-1.21](https://app.codecov.io/gh/theupdateframework/go-tuf/pull/606/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theupdateframework) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=theupdateframework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rdimitrov commented 9 months ago

Looks good, is the windows tests expected to fail?

@kommendorkapten - Yes, they were disabled before, but once we enabled them we saw there're a few issues when targets use the prefixed format we use in the tuf-demo repo.

I've opened an issue, but from what I see it's probably caused by the wrong handling of back/forward slashes when we are translating a target name to a local path name when we create or look for the target file locally.

I don't have a windows machine to properly debug and fix this, so I thought it's better to leave the tests enabled and failing until we get some help on this. Also this way we are open in sharing windows support is not working properly yet.