theupdateframework / tuf-on-ci-template

2 stars 1 forks source link

fix: publish workflow test permissions #27

Closed mrjoelkamp closed 3 months ago

mrjoelkamp commented 4 months ago

Summary

A little hard to test github actions and ended up finding a bug from https://github.com/theupdateframework/tuf-on-ci-template/pull/25 where publish calls the test without contents: read

Error calling workflow '.github/workflows/test.yml@5bdbcc8094b67c489fa12f9b746ab31add7b0972'. The nested job 'smoke-test' is requesting 'contents: read', but is only allowed 'contents: none'.

part of https://github.com/theupdateframework/tuf-on-ci-template/issues/24

mrjoelkamp commented 4 months ago

apologize for the extra PR but hard to test for this since running the job manually doesn't reproduce the error 😅

jku commented 3 months ago

Yeah would be nice to have CI testing for these but I don't see a way to do that without a lot of complexity