signer: Don't require python > 3.9 at runtime

theupdateframework / tuf-on-ci

A TUF repository and signing tool

Other

20 stars 11 forks source link

signer: Don't require python > 3.9 at runtime #407

Open jku opened 3 weeks ago

jku commented 3 weeks ago

Apparently Mac OS Python is 3.9. We should not use 3.10 features in signer and should not require it.

we use annotation features from 3.10 like str | None instead of Optional[str] (unsure if this breaks runtime or not, it definitely does break linting)
glob.glob() root_dir argument was added in python 3.10
maybe something else

jku commented 3 weeks ago

We should also run CI on MacOS (using system python) -- this requires also making repository work on 3.9 since the E2E tests would be necessary

jku commented 1 week ago

We should also run CI on MacOS (using system python) -- this requires also making repository work on 3.9 since the E2E tests would be necessary

I've added macos to signer lint and test matrix but did not include e2e tests: making the repository work on 3.9 requires annoying downgrades of urllib3 which I'd rather not do