[bug] The beep in the account selection menu gets a bit annoying

theurichde / go-aws-sso

Makes dealing with AWS SSO Logins an ease

MIT License

111 stars 15 forks source link

[bug] The beep in the account selection menu gets a bit annoying #124

Closed XenGi closed 1 year ago

XenGi commented 1 year ago

Describe the bug

When selecting the account from the menu. It beeps every time one presses the arrow keys. This get pretty annoying after a while and could be not so nice in the office.

To Reproduce Steps to reproduce the behavior:

Execute go-aws-sso
press arrow keys

Expected behavior

No audible beep when operating the menu.

Error Output

beep :P

theurichde commented 1 year ago

Hi @XenGi!

Thanks for reporting this issue. As my alert bell is always turned off by default in my terminal, I didn't notice this ever 😅

This seems to caused by / related to: https://github.com/manifoldco/promptui/issues/49

I will take a look on the code later on 🕵🏼‍♂️

theurichde commented 1 year ago

Hi @XenGi 👋🏼

Locally, I can not reproduce the issue for my terminal + shell, so I need your help here. I implemented a suggested fix from promptui and released v1.3.1-dev.1

Would you like to test if the bell is not ringing anymore with this fix? Thanks!

theurichde commented 1 year ago

Fixed with #127