search

theurichde / go-aws-sso

Makes dealing with AWS SSO Logins an ease
MIT License
111 stars 15 forks source link

[bug] Doesn't respect the BROWSER environment variable #130

Closed XenGi closed 1 year ago

XenGi commented 1 year ago

Describe the bug

The tool doesn't respect the environment variable BROWSER which can be used to temporarily set a different default browser in a shell.

I use this to use a different browser for some tools that require it or to separate work from private projects.

To Reproduce Steps to reproduce the behavior:

go-aws-sso
export BROWSER=google-chrome-stable
aws s3 ls
# opens system wide default browser (chromium) instead

Expected behavior go-aws-sso should check the content of the BROWSER variable and try to use that binary as the browser first. If that fails it should use xdg-open to get the systems default browser.

Error Output No error just unexpected behaviour.

XenGi commented 1 year ago

Any progress on this one?

theurichde commented 1 year ago

Hey there 👋🏻

It's on the To-Do List. PRs are also very welcome

XenGi commented 1 year ago

No worries. Maybe I'll give it a shot. Haven't found time so far.

theurichde commented 1 year ago

I just started working on this

theurichde commented 1 year ago

(auto-closed, nice)

@XenGi Please check v1.4.0-beta and tell me if the BROWSER env var feature behaves as expected 😄

XenGi commented 1 year ago

@theurichde This works perfectly. Thx!