theus / instantgram

:cloud: A bookmarklet for download photos in Instagram
http://theus.github.io/instantgram
Other
470 stars 43 forks source link

Can't add bookmarklet into Firefox #102

Closed version365 closed 2 months ago

version365 commented 2 months ago

Tried adding the new version into a new firefox profile. it's not adding. The add new bookmark dialogue is opening, but the bookmark is not getting added anywhere. it shows error invalid value for property url I tried some other bookmarklets from https://www.jeffersonscher.com/res/sumomarklets.html those are getting added though. Here are the error messages,

Error: Bookmarks.sys.mjs: fetch: Invalid value for property 'url': "javascript:\"use strict\";function _array_like_to_array(arr,len){(null==len||len>arr.length)&&(len=arr.length);for(var i=0,arr2=new Array(len);i<len;i++)arr2[i]=arr[i];return arr2}function _array_with_holes(arr){if(Array.isArray(arr))return arr}function _array_without_holes(arr){if(Array.isArray(arr))return _array_like_to_array(arr)}function _assert_this_initialized(self){if(void 0===self)throw new ReferenceError(\"this hasn't been initialised - super() hasn't been called\");return self}function _class_call_check(instance,Constructor){if(!(instance instanceof Constructor))throw new TypeError(\"Cannot call a class as a function\")}function _defineProperties(target,props){for(var i=0;i<props.length;i++){var descriptor=props[i];descriptor.enumerable=descriptor.enumerable||!1,descriptor.configurable=!0,\"value\"in descriptor&&(descriptor.writable=!0),Object.defineProperty(target,descriptor.key,descriptor)}}function _create_class(…
    validateItemProperties resource://gre/modules/PlacesUtils.sys.mjs:783
    validateBookmarkObject resource://gre/modules/Bookmarks.sys.mjs:3016
    fetch resource://gre/modules/Bookmarks.sys.mjs:1561
    bookmarkLink chrome://browser/content/browser-places.js:465
    bookmarkLink chrome://browser/content/nsContextMenu.js:2426
    oncommand chrome://browser/content/browser.xhtml:1

Places - Transactions: 
Failed to execute batched transaction: Error: Bookmarks.sys.mjs: insert: Invalid value for property 'url': "javascript:\"use strict\";function _array_like_to_array(arr,len){(null==len||len>arr.length)&&(len=arr.length);for(var i=0,arr2=new Array(len);i<len;i++)arr2[i]=arr[i];return arr2}function _array_with_holes(arr){if(Array.isArray(arr))return arr}function _array_without_holes(arr){if(Array.isArray(arr))return _array_like_to_array(arr)}function _assert_this_initialized(self){if(void 0===self)throw new ReferenceError(\"this hasn't been initialised - super() hasn't been called\");return self}function _class_call_check(instance,Constructor){if(!(instance instanceof Constructor))throw new TypeError(\"Cannot call a class as a function\")}function _defineProperties(target,props){for(var i=0;i<props.length;i++){var descriptor=props[i];descriptor.enumerable=descriptor.enumerable||!1,descriptor.configurable=!0,\"value\"in descriptor&&(descriptor.writable=!0),Object.defineProperty(target,desc…
theus commented 2 months ago

Hey, I changed the build system recently, and it looks like was compromising Firefox version. Now I can add the bookmark but it seems that is not working well as in the Chrome 🤔😢

version365 commented 2 months ago

Maybe you can have 2 different versions for the different browsers. I know it can be quite the headache to maintain 2 diff versions though! 😬 btw, thanks a lot for fixing it. 😍