thevalencyproject / valency-core

Key modular components used to build the Valency Network
https://valency.dev
GNU Lesser General Public License v2.1
4 stars 0 forks source link

AES-Encryption Segmentation Fault #2

Closed isaacljubic closed 1 year ago

isaacljubic commented 1 year ago

There is a segmentation fault in the AES keyExpansion() function... I believe the fault is to do with the expandedKeys vector not containing anything when I try to set the first 16 bytes to the original key (line 12). This will be fixed shortly :)

isaacljubic commented 1 year ago

I believe I have fixed the problem by adding this code before line 12: expandedKeys.resize(keysize + 1) * rounds
Please note that this implementation is not recommended, as modern CPU architectures have hardware implementations of this kind of encryption (more secure and probably faster)!!!