Follow up of PR #5 - Githubissues

thevasudevgupta / gsoc-wav2vec2

GSoC'2021 | TensorFlow implementation of Wav2Vec2

Apache License 2.0

88 stars 29 forks source link

Closed thevasudevgupta closed 3 years ago

thevasudevgupta commented 3 years ago

This is the follow up of PR #5.

Major Change:

@sayakpaul @MorganR

thevasudevgupta commented 3 years ago

I have submitted PR for exporting saved-model here: https://github.com/tensorflow/tfhub.dev/pull/65

thevasudevgupta commented 3 years ago

@sayakpaul, @MorganR,

notebook is ready for final review !!

Major changes:

worked on all the suggestions in notebook by @sayakpaul
hub.KerasLayer now can take the link directly (no need of extra thinking about signature)
Added argparse support for conversion script

thevasudevgupta commented 3 years ago

Merging this PR to be able to access link of the notebook from TFHub. But open for any kind of feedback (will work on that in another PR).