thevickypedia / Jarvis

Fully Functional Voice Based Natural Language UI
https://jarvis-health.vigneshrao.com
MIT License
207 stars 41 forks source link

i have install all packages for jarvis #26

Closed ShahwaizRaza closed 2 years ago

ShahwaizRaza commented 2 years ago

but it shows an error every time No module named 'executors.commander' or executors.geolocator or import geo_locator

thevickypedia commented 2 years ago

Thanks for reporting. From the description it sounds like your current working directory has an issue since executors dir is a part of the main module. Can you please provide minimum reproducible code or screenshots for me to begin with? Please refer to reporting guidelines on the information to include when you raise a bug report.

ShahwaizRaza commented 2 years ago

Thank you for your reply, I have downloaded all packages which are required . image . here is the code which is not running.

and here is the error. image


when I run internet.py separately it shows executors error image


image

thevickypedia commented 2 years ago

Can you please check the current working directory of your project. A pwd in working terminal or import os; print(os.getcwd()) should get it. Since both modules and executors are directories within the main module, there shouldn't be a start up issue unless the current working directory is incorrect.

To answer to your second screnshot, internet.py cannot be run separately so that is expected. Only jarvis.py can be triggered from the root dir which should import all the required modules and startup.

ShahwaizRaza commented 2 years ago

Command 'netsh wlan show interfaces' returned non-zero exit status 1. image

thevickypedia commented 2 years ago

Can you check if the command works in your terminal, I barely use windows OS and it was working in my machine after I installed git Let me know if that doesn't fix, I'll release a bug fix with exception handlers around it since it is an un-important task.

thevickypedia commented 2 years ago

Thanks for bringing this up, I just realized I'm checking for git installation in MacOS but not Windows I'll release a fix for that as well

ShahwaizRaza commented 2 years ago

git already installed in windows.

thevickypedia commented 2 years ago

The problem you stated shouldn't rely on git installation in the first place, can you try the command netsh wlan show interfaces in your cmd and see if it works.

ShahwaizRaza commented 2 years ago

wait, I am using pc not a laptop. image

ShahwaizRaza commented 2 years ago

i add try & except. image

then it shows this in terminal image

thevickypedia commented 2 years ago

Good to know, the command is to check wireless interfaces and I have never tried running on a wired PC I'll add that to my list of fixes in the next release. About the warning message, you may ignore it. It runs only on Mac with a cron schedule if you have robinhood credentials stored as env vars but imports the module regardless. You shouldn't have received the warning in the first place since both your CWD and Parent are the same. It might be because of spaces or backslashes. I implement a fix for that as well.

ShahwaizRaza commented 2 years ago

my current and parent directory are not the same. image

thevickypedia commented 2 years ago

Of course it will not be the same when you run that piece of code by itself. Current is current and parent is the directory where the current dir is present. I was talking about your previous screenshot when you spun up Jarvis to Sentry Mode That's because it does a string match instead of a path match using os.path.normpath() or os.path.realpath() or os.path.abspath()

thevickypedia commented 2 years ago

Issue has been addressed in 93b57ccb21ec63e4c5f2a8108d5210a79f9244ae