Gets status of the first cover of multiple covers [garage door] but performs action on all at once - Githubissues

thevickypedia / Jarvis

Fully Functional Voice Based Natural Language UI

https://jarvis-health.vigneshrao.com

MIT License

209 stars 41 forks source link

Gets status of the first cover of multiple covers [garage door] but performs action on all at once #30

Closed thevickypedia closed 1 year ago

thevickypedia commented 1 year ago

Describe the bug

The current garage door controller can properly work only if a single garage door is setup in myq
Having more than one garage doors setup in myq can yield unexpected results like:
- Gets the status of the first door alone.
- Performs actions like open and close against all the doors.

Expected behavior

Keep names of garage doors stored as env vars and the main door as default.
This way, the particular door can be opened or closed when requested.

Additional context The bug is OS agnostic since myq uses api calls to perform actions.

thevickypedia commented 1 year ago

Fixed in https://github.com/thevickypedia/Jarvis/commit/84bc85190e64693d14424a357d08b1a9dca4becb