db_spawn_vehicles.pl update and added update_bans.pl

[wriley]

The current implementation of db_spawn_vehicles.pl did not allow one to spawn vehicles and do cleanup in a single pass. If any of the cleanup options were picked then vehicle spawning was skipped. I patched it to allow spawning or cleaning or both as desired.

update_bans.pl is a script I've been using for a while to merge various ban lists with my own private bans. If you think it is useful you can add it in.

[thevisad]

This is not the desired effect, the effect cleanup should ONLY cleanup vehicles, it should not also spawn vehicles.

[wriley]

I disagree, but it's your project. :)

This restores the historical functionality of the script that was changed with commit 4c3eee0 and also adds the option of doing only a clean if that is desirable. I've always made a call to db_spawn_vehicles with '--cleanup all' and after 4c3eee0 I got no more vehicles spawning until I noticed the change in script logic.

[thevisad]

Please provide a valid argument for the case, to me, the verbiage --cleanup is not synonymous with adding new vehicles and is only confusing in the long run to new users. Existing users may feel differently regarding this aspect, but I am trying to address a great number of issues like this throughout the entire system.

I would like some other users to weigh in on this as well if possible?

[wriley]

My valid argument is that it has always worked this way until you changed it recently. ;) But to your point, why have cleanup in a script called db_spawn_vehicles.pl at all? db_cleanup.pl seems more appropriate.

[madrigo64]

1) I don't understand why was changed db_spawn_vehicles system for cleanup and spawn 2) I don't see normal information how to use now this script, if I use perl db_spawn_vehicles --help I got old uncorrected help info usage: db_spawn_vehicles.pl [--instance ] [--limit ] [--host ] [--user ] [--pass ] [--name ] [--port ] [--cleanup tents|bounds|all] we need to add some examples 3) Maybe wriley right, and have sense to separate cleanup functions to db_cleanup.pl ?

Very important to display examples how to use it.

[dzoeteman]

I do have to agree with @wriley on the cleanup being in db_spawn_vehicles. It does not make much sense, while all the other cleanup options are in db_utility.pl.

[xyberviri]

arguably the issue is that having some cleanup functionality in the spawn script is what's causing the confusion. however the clean routine only deletes vehicles from the instance table when fully damanged. and those wouldn't spawn anyway because destroyed vehicles dont spawn. so really we should remove the cleanup functionality from spawn vehicles On Feb 27, 2013 5:09 PM, "gdscei" notifications@github.com wrote:

I do have to agree with @wriley https://github.com/wriley on the cleanup being in db_spawn_vehicles. It does not make much sense, while all the other cleanup options are in db_utility.pl.

— Reply to this email directly or view it on GitHubhttps://github.com/thevisad/DayZ-Private-master/pull/150#issuecomment-14206424 .

[thevisad]

I added the update_bans, but I will be handling the cleanup differently. We will be moving this to other files to try and eliminate the confusion.

[wriley]

Sounds good, thanks.