search

thewca / statistics

12 stars 16 forks source link

Stat includes cancelled competitions #86

Closed beranka closed 2 years ago

beranka commented 2 years ago

Description: This statistic probably includes cancelled competitions, because the only competition in Czechia, that was in 2020, was Kostelec Open 2020, which was cancelled due to the pandemic.

Expected behaviour: It shouldn't count cancelled competitions, since those didn't actually happened.

Fixing this should be very easy, since there are columns cancelled_at and cancelled_by in the Competitions table, that should probably be null for competitions that weren't cancelled.

beranka commented 2 years ago

Oh, just noticed it's already in #77 from 2 months ago, just with a bit confusing name, sorry.