thewca / statistics

12 stars 16 forks source link

Success streaks should order by RoundType.rank #89

Closed timreyn closed 1 year ago

timreyn commented 1 year ago

The query for "longest success streak" doesn't sort by RoundType.rank (https://github.com/thewca/statistics/blob/6f98049999b6edf1977ad6d9523053c662328cff/misc/python/statistics/longest_success_streak.py). This means that, for competitions with multiple rounds, it's nondeterministic what order they are returned in.

I noticed this for my clock success streak. Last week it was 116 (correct), early this week it dropped to 111, and when AmherstOpen2022 results were added it went back up to 116 (should be 121 now). My last DNF was in round 1 of a 2-round competition, so the finals of that competition appear to be switching back and forth between being included and not.

Thank you!