search

thewca / tnoodle-lib

scrambling code portion of TNoodle
GNU General Public License v3.0
39 stars 15 forks source link

Rename *MIN_SCRAMBLE_LENGTH variables and check that they actually work #22

Open jfly opened 10 years ago

jfly commented 10 years ago

See https://github.com/cubing/tnoodle/issues/156#issuecomment-31508133 for renaming the variables, and https://github.com/cubing/tnoodle/issues/156#issuecomment-31574059 for checking that pyraminx and 222 are always solvable in exactly God's number turns.

@ChenShuang, do you think you can take this issue on when you've got some free time? There's no immediate rush here, but it's definitely something that should be done eventually.

cs0x7f commented 10 years ago

OK. I'll check the assumption in about 2 weeks. BTW, the solution of pyraminx does not include tips, which means that the length might larger than "MIN_SCRAMBLE_LENGTH" or "EXACT_SCRAMBLE_LENGTH".

lgarron commented 10 years ago

Wait, then how do we filter Pyraminx?

»Lucas Garron

On Wed, Jan 8, 2014 at 1:24 AM, Chen Shuang notifications@github.comwrote:

OK. I'll check the assumption in about 2 weeks. BTW, the solution of pyraminx does not include tips, which means that the length might larger than "MIN_SCRAMBLE_LENGTH" or "EXACT_SCRAMBLE_LENGTH".

— Reply to this email directly or view it on GitHubhttps://github.com/cubing/tnoodle/issues/158#issuecomment-31816055 .

cs0x7f commented 10 years ago

The length includes tips. The filtering is correct.

jfly commented 10 years ago

I believe Chen Shuang is referring to the SCRAMBLE_LENGTH_INCLUDES_TIPS boolean in PyraminxPuzzle.java. I vaguely remember us having to deal with this.