search

thewca / tnoodle-lib

scrambling code portion of TNoodle
GNU General Public License v3.0
39 stars 15 forks source link

Change Square-1 yellow to dark gray #50

Open alexmaasswca opened 5 months ago

alexmaasswca commented 5 months ago

Changed Square-1 yellow to dark gray by adding a new color, this is the most common square-1 color scheme, and fixes the problem with yellow and white contrasting, this would make it easier to check scrambles, and also make it easier on our eyes. The community has already voiced support for this change. https://forum.worldcubeassociation.org/t/change-clock-and-square-1-color-scheme-on-tnoodle-scramble-pdfs-to-white-black/42647

Obviously I know you can change it manually, but I think it would be good to change the default for the reasons above.

Before: image

After: image

gregorbg commented 5 months ago

Thank you for your submission, it is a reasonable proposal! The code looks fine, but I am holding off the merge because it would require me to compile new releases for all current TNoodle binaries (which is something I'm not willing to do with potential replacement solutions on the horizon)