search

thewca / tnoodle

Development for the official WCA scramble server
https://www.worldcubeassociation.org/regulations/scrambles/
GNU Affero General Public License v3.0
393 stars 93 forks source link

Null pointer exception when generating 777 page #125

Closed jfly closed 10 years ago

jfly commented 10 years ago

Here's the curl:

curl 'http://localhost:8080/view/777nullpointer.pdf' --data 'scrambles=%5B%7B%22scrambles%22%3A%5B%22Dw2+R+3Uw%27+3Fw%27+3Bw+F%27+3Uw2+Bw+F%27+Rw%27+B2+Rw2+3Bw%27+3Rw2+3Dw2+3Uw+3Fw2+Dw%27+Rw2+3Dw+Dw2+F%27+U2+Dw2+F+Lw+3Fw+R%27+3Bw+3Rw%27+3Lw%27+3Uw2+3Fw+Lw+3Fw+Rw2+3Fw2+Bw+3Uw%27+Fw%27+3Lw%27+3Uw%27+F2+Dw+3Lw%27+U%27+Rw2+U+Uw2+Rw%27+F2+B%27+Rw+Uw2+D%27+3Bw+3Uw%27+3Rw2+Bw+3Dw%27+Rw2+Uw+3Uw2+Dw+3Rw%27+3Bw+F+L2+3Uw%27+L2+Dw2+3Lw%27+U+3Fw+L%27+Dw%27+3Bw2+3Uw%27+F%27+Rw2+3Bw2+3Fw2+Fw+Bw%27+3Dw%27+Uw%27+R2+D2+B%27+3Uw2+L2+3Dw%27+Lw+3Uw%27+3Rw+L%27+3Dw%27+Uw%27+Bw%27+3Lw%27%22%2C%22F%27+3Rw+Dw+3Uw2+3Dw2+Rw+L2+F2+3Rw2+R%27+3Fw%27+L%27+R2+3Fw+Fw2+Lw+3Lw2+B2+3Uw%27+F2+3Fw+Lw%27+R2+Fw+3Bw+B2+F%27+3Lw+3Bw2+R%27+D2+L+Fw+Lw2+R%27+L%27+3Rw%27+3Lw%27+Uw+B+D2+3Lw2+3Bw+3Fw+Bw2+U+3Fw%27+Fw2+R2+3Dw%27+Rw2+3Bw%27+Rw+3Lw+Uw+3Rw2+Dw%27+3Uw+3Bw+Rw2+Fw2+3Fw2+Bw2+3Lw2+F2+D2+R2+Dw%27+3Dw+3Lw+Lw%27+3Uw+Rw+R+B2+U+3Rw2+U%27+3Bw2+L+D2+B+U2+B2+Dw+R+3Lw+3Uw2+3Lw2+R2+3Fw%27+D%27+R%27+Lw+3Dw+Rw+Lw2+L2+3Rw%27+U%27%22%2C%22Bw%27+Uw+Lw%27+3Uw+3Dw%27+Bw%27+3Dw%27+Uw+Dw2+3Rw2+U+Dw+Uw+R2+3Dw2+R2+Uw+Fw+Dw+Fw2+Uw%27+Lw%27+3Rw%27+Dw%27+3Fw2+R%27+Lw2+L%27+3Uw+Bw2+3Lw+Fw%27+D+B+3Bw%27+D%27+L2+3Rw2+U2+Rw2+Bw+L%27+Dw%27+3Bw2+3Uw+U+Uw+Lw+3Dw+3Bw%27+F%27+B%27+R2+Fw+3Lw+Uw+U+3Fw+Rw2+3Rw%27+3Fw%27+Fw+Bw2+3Bw+B+D+3Uw2+3Bw2+Rw+3Lw2+3Rw2+R2+D%27+Uw2+3Uw2+Rw+3Bw%27+B+Dw2+Lw%27+3Rw2+Fw%27+Uw%27+L%27+Dw2+3Dw%27+L+D%27+3Rw+3Fw%27+3Rw%27+Lw%27+D2+Dw2+Uw%27+3Bw+F+R+Rw+Fw%22%5D%2C%22extraScrambles%22%3A%5B%22Dw+3Lw2+3Uw%27+D2+Fw%27+Dw+3Dw+Fw+F2+Bw+D%27+Bw2+Rw%27+3Fw%27+L2+3Uw+U%27+B2+3Dw%27+3Rw2+Dw+Bw2+Rw+Dw+Rw%27+3Uw%27+L%27+Rw+Lw+3Uw2+Dw+3Fw2+3Rw%27+3Bw2+Dw%27+U%27+3Dw2+3Rw+L%27+D+3Lw2+3Uw+Lw%27+D+R2+U+3Bw2+3Uw+3Fw%27+Fw%27+Dw2+B+F+L+Uw2+Fw+3Fw+U2+F%27+3Bw%27+L+F+B+3Fw2+3Bw%27+U+R+Dw2+Uw+U2+F2+U%27+3Fw%27+Bw2+L+3Uw2+F2+U2+Uw+3Lw2+U%27+3Rw%27+F2+L+U%27+B2+3Uw%27+Dw%27+Rw+Bw+L2+3Uw+R%27+Rw2+3Lw%27+3Dw2+3Rw2+Rw2+Dw%27+D%27%22%2C%22Rw%27+L+D2+3Fw%27+3Uw%27+D+Dw%27+Lw2+3Bw%27+U%27+3Bw+Uw2+U+3Uw2+Bw2+3Bw+D2+3Lw%27+3Rw2+3Dw2+Bw%27+F2+3Rw%27+F+3Fw2+3Lw2+R+3Uw%27+3Fw+Uw+3Lw2+3Fw2+D2+Uw%27+3Rw%27+L2+3Lw2+3Dw%27+3Uw2+Dw%27+Uw2+Fw+3Fw2+3Dw+B+Rw2+Uw+U2+B%27+Dw%27+Uw+Rw%27+R+Fw+3Lw2+3Rw%27+L+D2+Uw+Lw+Uw%27+Fw2+U+Uw2+Bw+3Dw+Dw2+Bw+3Uw%27+R2+F2+B+Dw2+3Bw+Uw%27+U%27+B+3Uw+Lw2+F2+Bw+3Rw+3Bw+Rw%27+3Uw2+Bw%27+3Uw%27+F2+L2+Lw2+Rw+F%27+3Rw%27+3Bw2+L%27+Rw2+Uw+3Fw%27+3Rw2+R%22%5D%2C%22copies%22%3A1%2C%22scrambler%22%3A%22777%22%2C%22title%22%3A%227x7+Cube+Round+1%22%2C%22fmc%22%3Afalse%7D%2C%7B%22scrambles%22%3A%5Bnull%2Cnull%2Cnull%5D%2C%22extraScrambles%22%3A%5Bnull%2Cnull%5D%2C%22copies%22%3A1%2C%22scrambler%22%3A%22777%22%2C%22title%22%3A%227x7+Cube+Round+2%22%2C%22fmc%22%3Afalse%7D%2C%7B%22scrambles%22%3A%5Bnull%2Cnull%2Cnull%5D%2C%22extraScrambles%22%3A%5Bnull%2Cnull%5D%2C%22copies%22%3A1%2C%22scrambler%22%3A%22777%22%2C%22title%22%3A%227x7+Cube+Round+3%22%2C%22fmc%22%3Afalse%7D%2C%7B%22scrambles%22%3A%5B%22Uw+3Bw%27+Fw+Rw+3Uw%27+Fw%27+3Uw%27+Rw2+Fw+F%27+3Bw+Bw%27+3Fw+3Uw+L2+Bw+3Bw+3Dw%27+Uw+Dw%27+L2+Bw+3Uw%27+R%27+Lw+B%27+3Fw2+3Bw+Fw2+Lw%27+U2+Fw2+3Fw2+Lw%27+3Lw%27+R2+3Fw2+3Bw+L%27+Dw%27+F+3Dw2+Dw%27+3Bw2+L%27+R2+3Fw%27+F+Rw%27+3Bw2+Bw+Dw2+R2+3Dw+U+F+B2+Rw%27+U%27+3Uw+F%27+Dw%27+L2+Dw%27+Fw%27+Dw+Rw+B+Lw+3Dw+3Fw+Uw%27+3Lw+3Uw%27+Dw%27+D+3Fw%27+3Bw2+Lw2+3Uw%27+R+L2+Rw%27+D+L2+3Uw2+3Lw+D+R2+F+Uw2+3Dw+R%27+3Lw2+F2+R2+Dw+3Dw2+Bw2+3Lw%27%22%2C%22F%27+Bw%27+3Uw+L2+Bw%27+B2+3Fw%27+L2+R%27+U%27+3Lw%27+U%27+Uw2+D+L+3Uw2+Dw%27+F2+Dw2+Bw2+3Fw%27+Fw%27+Uw+Bw%27+3Bw+R2+3Rw+Bw2+Dw+D2+U%27+Lw%27+D%27+B+Uw2+3Rw+Rw+3Lw+D+B2+Uw+Bw+Rw2+Uw%27+R+F%27+D2+L+3Dw+R2+Dw%27+3Lw%27+3Bw%27+Dw%27+3Bw2+3Dw%27+Uw2+U+F2+3Rw+U%27+Lw%27+3Dw+3Bw2+L+D%27+3Dw%27+L%27+3Lw%27+D+Dw+L+Dw%27+3Fw2+3Dw2+B%27+Rw+Dw2+Rw%27+Uw%27+3Rw2+3Uw2+Rw2+3Uw2+3Dw%27+Lw+L2+Bw+D2+3Uw2+Dw2+3Lw2+Fw+Lw%27+3Lw2+D2+3Dw%27+Lw2+Bw%27+Rw%22%2C%22U+Lw+L%27+3Fw2+3Rw2+B+3Fw%27+3Bw+Rw+Dw%27+L%27+Fw2+L2+3Lw2+B%27+3Lw2+3Rw%27+3Uw%27+L%27+U+Rw%27+F2+3Rw2+3Fw2+R2+3Rw%27+B+Fw+3Fw+3Dw+3Lw2+Uw2+3Rw+F+B%27+3Fw2+3Uw+Dw2+F%27+Lw%27+Fw+U%27+Dw2+3Fw2+Lw%27+3Lw2+Fw2+Rw2+Dw+R+3Fw+3Uw2+D%27+B%27+F%27+Fw%27+Bw%27+Uw2+Rw2+Dw2+U2+Uw2+3Dw+L%27+B2+Fw2+Uw%27+L2+D2+Uw+Rw+3Bw+Lw2+3Fw2+3Lw%27+D+Bw%27+3Fw%27+3Dw+R2+3Uw2+U2+3Rw+Uw+F%27+Fw2+3Bw2+Uw+Dw%27+3Uw2+Bw%27+Fw%27+3Rw%27+F%27+U%27+3Lw+D2+3Lw2+Uw2+B2%22%5D%2C%22extraScrambles%22%3A%5B%223Bw%27+L+3Dw%27+Fw%27+L+Lw2+3Dw+L2+3Fw+Rw2+3Bw%27+3Uw2+3Dw+3Fw2+3Dw+L2+3Rw%27+3Bw2+Fw+B+D%27+3Bw2+Lw%27+B2+3Lw2+Uw+L+3Rw+3Uw%27+3Lw+U+Uw%27+L+3Fw%27+Bw%27+F+3Rw2+3Bw2+Fw2+3Rw2+3Dw2+R%27+3Fw2+Dw%27+B+Bw+R+Dw+R2+D+Dw+3Lw%27+3Uw2+Lw2+Uw+3Uw%27+3Rw+F+3Lw+3Bw2+Bw%27+D2+3Dw2+3Lw2+D2+Lw+L+3Dw%27+R+Dw+3Uw%27+3Lw%27+Uw+3Lw2+3Rw%27+Uw2+Fw2+Dw2+F%27+3Dw2+3Uw+L+3Rw2+Rw2+3Uw%27+3Dw2+Uw2+Bw%27+3Lw2+Lw2+Bw2+Dw2+3Rw%27+3Dw%27+3Bw%27+Lw+3Uw+3Fw2+U%27+Fw%22%2C%22Uw+R%27+Bw+F+D+3Lw%27+Dw%27+F2+3Bw%27+B%27+3Rw%27+R%27+Bw%27+3Rw%27+Lw2+Rw2+3Lw2+B%27+Rw%27+3Lw+Uw+3Bw2+3Uw%27+B2+3Dw2+3Bw+U%27+3Lw%27+Bw+R+3Dw2+Rw+Lw%27+D2+Uw2+B%27+3Lw2+3Dw+Bw2+3Fw+F+L+Uw+Bw2+Lw%27+Dw2+Rw%27+3Bw%27+B+Lw+3Fw%27+F2+B2+3Lw%27+Rw2+B%27+R2+3Bw%27+Bw%27+L2+3Lw+Rw2+F2+R%27+Dw2+3Bw2+Rw+F+U%27+3Lw%27+Rw%27+3Uw2+B+3Rw+3Uw%27+3Bw%27+3Dw+3Fw+Lw2+3Lw+R+F+U+3Bw%27+F+Fw+B2+3Rw%27+Uw+F%27+R+Uw2+Bw+3Lw%27+F+B+R%27+B2+U%27+L2%22%5D%2C%22copies%22%3A1%2C%22scrambler%22%3A%22777%22%2C%22title%22%3A%227x7+Cube+Round+4%22%2C%22fmc%22%3Afalse%7D%2C%7B%22scrambles%22%3A%5B%22Dw+Lw2+3Dw+L2+Dw2+Lw%27+3Bw+B2+Uw+Dw2+3Rw+Rw2+3Lw%27+L2+3Fw+L2+B%27+R2+D%27+Lw%27+Uw%27+Rw2+Dw%27+3Fw%27+Uw2+B%27+3Fw+Fw+D2+3Lw2+R%27+3Rw%27+Bw%27+B%27+Dw+Uw%27+Fw2+R%27+F2+B%27+Dw+3Lw2+Fw2+3Fw2+3Lw%27+Uw%27+D2+3Lw2+L+U2+3Dw2+3Fw2+3Bw2+F2+3Lw%27+3Uw+Fw%27+R+Fw+3Fw%27+D%27+B%27+Dw%27+R+3Uw2+3Bw%27+L2+3Dw+Lw%27+D+B+F+Fw2+3Rw+Uw+Fw%27+Bw2+3Lw%27+3Dw2+3Lw+Rw%27+R+Uw%27+U+Dw+Fw%27+Uw%27+Fw2+3Lw2+F%27+3Lw+3Dw2+Uw2+Rw+L%27+B+Dw2+B2+3Rw2+U%22%2C%22D%27+Fw%27+Rw%27+Lw2+U2+Lw2+Bw+3Uw%27+Rw2+Lw%27+D+Lw+3Rw+3Fw2+3Dw+Lw2+U%27+Bw+3Lw+Rw%27+3Bw2+L+3Dw2+3Bw2+Fw%27+Uw+F2+U+L2+R2+Bw+3Bw+Uw2+Dw%27+U2+3Bw+3Uw+3Lw2+F2+Fw+3Dw+Uw+3Fw2+3Bw%27+Fw2+D%27+Lw2+B+Rw%27+D+Lw2+3Dw2+Bw2+D2+Rw%27+D2+R+U%27+3Uw%27+3Rw2+R%27+3Dw%27+Bw+Uw2+3Bw2+D2+R+3Bw%27+D2+3Fw+3Uw+U2+3Bw%27+Dw2+Rw+Bw+Uw2+F+D%27+Fw%27+Bw%27+Uw%27+Bw2+R%27+Bw%27+3Bw+3Lw2+F2+Bw2+3Rw+B%27+R%27+Uw2+Lw+3Uw+D+Uw+U+3Lw%27+3Fw%27%22%2C%22Rw2+3Bw+3Dw%27+Rw+D2+Dw%27+Lw+3Rw%27+3Lw%27+Uw%27+3Rw+3Lw%27+3Dw2+3Lw+D2+3Fw2+3Rw2+Bw+3Rw+R+Rw2+Fw2+Bw%27+R2+U+Lw%27+Dw+3Fw+B%27+D%27+Fw+Lw+B%27+3Dw2+Uw2+3Fw2+Uw%27+Lw2+F2+D+Lw2+3Uw2+3Dw%27+R%27+3Dw%27+Dw+3Bw%27+Bw2+3Rw+Fw+3Lw%27+3Rw+Uw+Rw+3Dw+3Bw%27+Fw2+Rw+Bw2+R2+U%27+B+Bw%27+3Fw2+3Lw2+Lw+B+R+3Bw+Dw+Uw+R%27+L%27+3Uw+R%27+3Dw2+L2+U+R2+F2+3Uw+R+Bw2+L+Uw+3Uw%27+3Lw2+B%27+D%27+U%27+Lw+Rw+B%27+3Uw+3Fw2+Uw%27+Bw2+L%27+Rw+3Fw%22%5D%2C%22extraScrambles%22%3A%5B%22Fw+R2+3Lw+Fw%27+Uw2+3Lw+Rw2+3Fw+3Bw+3Dw%27+3Bw2+Dw2+B+L2+Lw+3Bw2+F+Fw%27+3Lw%27+Bw%27+3Dw+3Bw%27+3Lw2+B%27+Uw%27+3Lw%27+B+Uw%27+D%27+L2+D2+B2+Dw+D+Rw%27+F2+Uw+3Rw2+F+3Fw2+3Lw%27+3Dw%27+3Fw+3Uw2+R%27+Lw+B%27+Fw+3Fw%27+Lw2+3Lw+3Bw2+B2+F%27+Rw%27+3Dw%27+3Uw2+Rw+3Bw%27+L%27+U2+F+D2+3Rw2+U2+Bw+3Dw%27+B2+Uw%27+D%27+3Dw%27+3Rw%27+Dw+B+U%27+Bw2+B2+Uw%27+F2+B2+Bw%27+3Bw2+3Uw%27+R+Fw%27+U%27+3Lw+3Rw+3Bw+Uw2+L%27+3Fw%27+3Uw%27+R+3Bw%27+3Lw2+Rw%27+B+U%27+F%22%2C%22U2+F+U%27+Fw2+L2+Fw+Bw+3Dw2+U2+Lw%27+Dw2+Fw2+L2+B2+Bw2+U2+Uw%27+3Rw+R%27+3Dw2+3Bw2+Lw2+3Bw+3Fw2+Lw2+R2+3Fw+Dw2+L+U+Bw2+Fw+Dw+Fw+3Bw2+L2+F2+Lw%27+3Dw2+Fw2+R+3Lw%27+Rw+3Dw2+Fw%27+D+3Bw+F2+D2+R2+3Rw+3Uw%27+3Bw+3Uw2+L2+B2+3Fw+L+Uw+3Bw%27+Bw%27+3Uw2+Lw2+3Rw%27+L%27+Rw%27+3Lw2+Dw2+U2+R+Bw+L+3Fw%27+3Lw%27+3Rw2+F2+U2+3Uw+D+Uw+F%27+3Fw2+Rw+3Dw2+Uw2+3Lw%27+Lw2+L2+3Bw+R2+L+3Dw%27+3Lw2+3Dw2+Bw2+Fw2+Uw2+D+Dw%27+3Fw%27%22%5D%2C%22copies%22%3A1%2C%22scrambler%22%3A%22777%22%2C%22title%22%3A%227x7+Cube+Round+5%22%2C%22fmc%22%3Afalse%7D%5D'
jfly commented 10 years ago

Hmmm... the curl command seems to just be returning "java.lang.NullPointerException", no backtrace. This is annoying. Maybe the server is trying to send the backtrace, but it's not getting properly flushed?

jfly commented 10 years ago

After restarting the tnoodle server, I discovered that this problem is still reproducible. I'm getting a full backtrace now, too:

java.lang.NullPointerException
        at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.padTurnsUniformly(ScrambleRequest.java:691)
        at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.createTable(ScrambleRequest.java:608)
        at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.addScrambles(ScrambleRequest.java:561)
        at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.createPdf(ScrambleRequest.java:241)
        at net.gnehzr.tnoodle.server.webscrambles.ScrambleRequest.requestsToPdf(ScrambleRequest.java:843)
        at net.gnehzr.tnoodle.server.webscrambles.ScrambleViewHandler.wrappedService(ScrambleViewHandler.java:210)
        at net.gnehzr.tnoodle.server.SafeHttpServlet.service(SafeHttpServlet.java:40)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:45)
        at winstone.ServletConfiguration.execute(ServletConfiguration.java:249)
        at winstone.RequestDispatcher.forward(RequestDispatcher.java:335)
        at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:378)
        at net.gnehzr.tnoodle.server.HtmlInjectFilter.doFilter(HtmlInjectFilter.java:40)
        at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
        at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
        at org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:176)
        at org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:145)
        at org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:92)
        at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:389)
        at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
        at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
        at winstone.RequestDispatcher.forward(RequestDispatcher.java:333)
        at winstone.RequestHandlerThread.processRequest(RequestHandlerThread.java:244)
        at winstone.RequestHandlerThread.run(RequestHandlerThread.java:150)
        at java.lang.Thread.run(Unknown Source)

Reproducing the truncated backtrace problem is going to be a real problem, though.

jfly commented 10 years ago

This is a problem with the frontend. For some reason, it's sending null scrambles to the backend. I think this is reproducible by clicking aggressively on the front end.

lgarron commented 10 years ago

In which case... this is sort of a known issue? It would be nice if TNoodle didn't crash on bad input, but we really just need it to be reliable enough for occasional delegate use.

Is this still a blocker for making 0.7.10 official?

»Lucas Garron

On Mon, Sep 30, 2013 at 4:32 PM, Jeremy Fleischman <notifications@github.com

wrote:

This is a problem with the frontend. For some reason, it's sending null scrambles to the backend. I think this is reproducible by clicking aggressively on the front end.

— Reply to this email directly or view it on GitHubhttps://github.com/cubing/tnoodle/issues/125#issuecomment-25415364 .

jfly commented 10 years ago

This was a known issue? Who ran into this before? #119 was for a different (although possibly related) issue.

Anyways, I found the bug and fixed it. @lgarron, I've created a pull request and assigned it to you https://github.com/cubing/tnoodle/pull/126.