search

thewca / wca-documents

Official Documents of the World Cube Association.
https://www.worldcubeassociation.org/documents
20 stars 37 forks source link

Spanish Translations Improvements #382

Closed Nanush7 closed 4 months ago

Nanush7 commented 4 months ago

@dmint789 Looks good?

dmint789 commented 4 months ago

@Nanush7 yeah, lgtm, I'll approve. Did you update the Spanish version accordingly? Does the current Spanish translation match the English version? Also, as a general thought, do you not think we're replicating the regulations a bit too much in this document now? It might require more maintenance that way. But if you think this is kind of necessary for a doc like this, we can leave it.

Nanush7 commented 4 months ago

@dmint789 Done! :)

Also, as a general thought, do you not think we're replicating the regulations a bit too much in this document now?

It's important to not give just half of the information, as it may lead to confusion. I agree we should keep it as simple as possible, but I don't think the current version replicates the regulations that much.

dmint789 commented 4 months ago

@Nanush7 LGTM. Can you remind me, do you have the rights to merge? If not, I'll squash merge this for you.

Nanush7 commented 4 months ago

I didn't know we had the right to merge, but looks like we do. :p

dmint789 commented 4 months ago

Yeah, I requested the rights last year