Open JonEsparaz opened 1 year ago
I don't have a strong opinion on the decision specifically, but I'm not certain that changing the behaviour of WCA Live alone is the way to go.
The WCA website treats organizers as "competition managers", the implication is that they have permission to update WCIF anyway. For instance, they can modify the competition with a tool such as Groupifier, which I think is essential. Similarly, an organizer can import a competition, because when we ask the WCA API for manageable competitions of the given user, it would return competitions where the person is an organizer; we could surely then filter only those where the person is actually a delegate, but this is just another indicator that we are only seemingly limiting the access.
Principle of least privilege :)
IMO, and as mentioned in https://github.com/thewca/worldcubeassociation.org/issues/7168#issuecomment-1232367510, organizers should not have manager/scoretaker access by default. I think only delegates need manager access (to add/remove scoretakers), then they can add other users (including organizers) as scoretakers as needed (or give out one-time codes).
Relevant code here:
https://github.com/thewca/wca-live/blob/8d60f55a30483fd69b9f47d8966aea88fa75fed0/lib/wca_live/competitions/staff_member.ex#L45
I'm happy to make this PR if there's no resistance from the WST or a majority of Delegates regarding application hehaviour.