search

thewca / wca-live

Platform for running WCA competitions and sharing live results with the world
https://live.worldcubeassociation.org
70 stars 23 forks source link

Recalcuate regional records tags if a user's region changes and they have a record tag #192

Open dunkOnIT opened 1 year ago

dunkOnIT commented 1 year ago

This prevents situations like this user achieving Yemenese NR, having their region changed to US, and showing up as having achieved a US national record.

image

jonatanklosko commented 1 year ago

Ideally it would update, although in practice it's very unlikely because it requires the competitor to change country right before or during the competition. And in cases like this it's enough to resubmit the result to force record tags to be recomputed.

dunkOnIT commented 1 year ago

Do you suggest we close this issue and just use resubmitting the results as a manual workaround?

Also, how were you resubmitting the results? Literally just bringing up their scorecard input and submitting it again?

jonatanklosko commented 1 year ago

Do you suggest we close this issue and just use resubmitting the results as a manual workaround?

Yeah, IMO it's not worth the additional complexity, given how rare this is.

Also, how were you resubmitting the results? Literally just bringing up their scorecard input and submitting it again?

No need for scorecard, you just go to the round editing, select the given competitor and re-submit the results form (it is already filled with the entered times).