thewca / wca-live

Platform for running WCA competitions and sharing live results with the world
https://live.worldcubeassociation.org
70 stars 23 forks source link

Former WRs are not converted into CRs or NRs #210

Closed OtaMota closed 6 months ago

OtaMota commented 6 months ago

Recently, Dilshawn got a 3.35 WR average. However, Niklas got a 3.31 the day after. Dilshawn's 3.35 should now be converted into NAR, but it is not to be found. Screenshot 2024-02-18 at 12 24 55

It instead uses the 4.21 NR average he got the previous round. Screenshot 2024-02-18 at 12 26 34

The problem is that the 4.21 is no longer NR, the Former WR 3.35 is. Hopefully this can soon be fixed.

jonatanklosko commented 6 months ago

This is by design. The record tags represent the status from where the result happened, so if it is broken soon after, it should remain as WR. In the record list specifically, we want to avoid duplicates, so if there are multiple records (in this case WRs) of the same kind, we only show the better one.

It is a bit confusing in this case, because there is also the NR that we don't filter out, but the alternative of showing both WRs would probably be even more confusing (even more so for CRs and NRs which can be broken quite often).

Note that the record tags in WCA Live are not "binding", they are just indicators. For example if there two WRs at different competitions at the same day, only one of them will eventually be considered as WR in the official rankings, but in WCA Live we show both as WRs, because we limit record computation to each competition itself.