Open mckeenicholas opened 7 months ago
There are still grammar mistakes, BTW: "rounds with less than N competitors..." should be "with fewer than N competitors..."
Also, just a suggestion, why not use the actual rule text which is subtly different, even if semantically the same as yours:
9m1) Rounds with 99 or fewer competitors must have at most two subsequent rounds.
9m2) Rounds with 15 or fewer competitors must have at most one subsequent round.
9m3) Rounds with 7 or fewer competitors must not have subsequent rounds.
I've updated the text to use the regulation text. The original code had a check for having at least 8 competitors in the previous round which was formatted in the same way I wrote them, which was my reasoning for keeping it in the same format. (I also find "fewer than 100" more understandable than "99 or fewer", but its probably better to use the actual regulation text).
@mckeenicholas thanks, a couple small comments. Also, please add one more test similar to this one:
Closes #186
I've only implemented the check on the server side as of now. I can add a client side check as well if necessary.